Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] mail_post_defer: Add notes to readme #1616

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

nobuQuartile
Copy link
Contributor

@nobuQuartile nobuQuartile commented Mar 7, 2025

@qrtl
QT4601

We encounter an issue where scheduled messages are not sent because the cron job "Notification: Send scheduled message notifications" (mail.ir_cron_send_scheduled_message) is inactive.

The cron record is triggered here:
https://github.com/OCA/OCB/blob/16.0/addons/mail/models/mail_message_schedule.py#L39

and it's ignored if not active:
https://github.com/OCA/OCB/blob/16.0/odoo/addons/base/models/ir_cron.py#L486C9-L492C67

@OCA-git-bot
Copy link
Contributor

Hi @yajo,
some modules you are maintaining are being modified, check this out!

@nobuQuartile nobuQuartile marked this pull request as ready for review March 7, 2025 09:00
@nobuQuartile nobuQuartile marked this pull request as draft March 7, 2025 09:01
@nobuQuartile nobuQuartile marked this pull request as ready for review March 26, 2025 02:46
Comment on lines 8 to 13
To ensure that messages are sent as expected, make sure that "Notification: Send
scheduled message notifications" (mail.ir_cron_send_scheduled_message) is enabled.
Odoo can usually send the emails even if this scheduled action is disabled, but
with this module installed, the emails will not be sent unless it is enabled.

#. Go to *Settings > Technical > Automation > Scheduled Actions*.
#. If "Notification: Send Scheduled Message Notifications" is not active, enable it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid introducing a new topic while explaining another.

Suggested change
To ensure that messages are sent as expected, make sure that "Notification: Send
scheduled message notifications" (mail.ir_cron_send_scheduled_message) is enabled.
Odoo can usually send the emails even if this scheduled action is disabled, but
with this module installed, the emails will not be sent unless it is enabled.
#. Go to *Settings > Technical > Automation > Scheduled Actions*.
#. If "Notification: Send Scheduled Message Notifications" is not active, enable it.

Instead, update the first sentence as follows:

You usually don't need to do anything. The module is configured appropriately out of the box. Just make sure the following server actions are active:

- Mail: Email Queue Manager (mail.ir_cron_mail_scheduler_action)
- Notification: Send scheduled message notifications (mail.ir_cron_send_scheduled_message)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nobuQuartile nobuQuartile force-pushed the 16.0-imp-mail_post_defer branch 4 times, most recently from 8f2defe to 9e0d2f5 Compare March 27, 2025 00:27
@nobuQuartile nobuQuartile changed the title [IMP] mail_post_defer: Added notes to readme [16.0][IMP] mail_post_defer: Added notes to readme Mar 27, 2025
@nobuQuartile nobuQuartile force-pushed the 16.0-imp-mail_post_defer branch from 9e0d2f5 to 69ef92c Compare March 27, 2025 01:29
@nobuQuartile nobuQuartile changed the title [16.0][IMP] mail_post_defer: Added notes to readme [16.0][IMP] mail_post_defer: Add notes to readme Mar 27, 2025
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants