[FIX] sign_oca: restricted company logo max-height to prevent l…

[anasassi119]

…arge logos from affecting the size of the signing area

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Isn't this still deforming images? What about max-height?

[anasassi119]

I don't think it would deform images, image deformation occurs when you change the aspect ratio of the image, here, we're simply restricting the height of the logo so that it wouldn't affect the signing area.

In a signing module, what are your priorities? Even deforming the logo a little bit is fine as long as the signing area is big enough.

An example of the problem this fixes:

Before

After

[pedrobaeza]

OK then

[etobella]

As stated on #100, use max-height, not height. If you use height with a small logo, the logo will be pixeled.

You will receive the same benefits but other people will not have problems.

Also, fix the commit name (you don't need the [17.0] on the commit, just on the Pull REquest. If possible, avoid two PR, just ammend the current and push force to replace the current commit.

For example, to fix this you could use:

git commit --amend
git push -f

[anasassi119]

Silly me thought I used max-height in this PR. Updated.