Skip to content

[17.0][MIG] helpdesk_timesheet_time_type: Migration to 17.0 #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025

Conversation

lbarry-apsl
Copy link
Member

@mpascuall
Copy link
Contributor

Hi @lbarry-apsl. This module depends on hr_timesheet_time_type which is not migrated to v17. Once a pr is created, you should follow this guideline: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@lbarry-apsl
Copy link
Member Author

lbarry-apsl commented Apr 10, 2025

@lbarry-apsl lbarry-apsl force-pushed the 17.0-mig-helpdesk_timesheet_time_type branch from f60e636 to 6af3bf4 Compare April 10, 2025 14:08
@lbarry-apsl
Copy link
Member Author

Hi @lbarry-apsl. This module depends on hr_timesheet_time_type which is not migrated to v17. Once a pr is created, you should follow this guideline: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Done! Thanks!

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat!

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbarry-apsl
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @lbarry-apsl you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@lbarry-apsl
Copy link
Member Author

@pedrobaeza , can this be merged?

@pedrobaeza
Copy link
Member

/ocabot migration helpdesk_timesheet_time_type
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 14, 2025
OCA-git-bot added a commit that referenced this pull request Apr 14, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Remove the temporary reference.

@pedrobaeza pedrobaeza closed this Apr 14, 2025
@pedrobaeza pedrobaeza reopened this Apr 14, 2025
@lbarry-apsl lbarry-apsl force-pushed the 17.0-mig-helpdesk_timesheet_time_type branch from 6af3bf4 to 6a3b12f Compare April 14, 2025 07:14
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 57ac008 into OCA:17.0 Apr 14, 2025
9 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e05eb55. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants