-
-
Notifications
You must be signed in to change notification settings - Fork 345
[17.0][MIG] helpdesk_timesheet_time_type: Migration to 17.0 #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] helpdesk_timesheet_time_type: Migration to 17.0 #721
Conversation
Hi @lbarry-apsl. This module depends on hr_timesheet_time_type which is not migrated to v17. Once a pr is created, you should follow this guideline: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
Depends on:
|
f60e636
to
6af3bf4
Compare
Done! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/ocabot merge nobump |
Sorry @lbarry-apsl you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@pedrobaeza , can this be merged? |
/ocabot migration helpdesk_timesheet_time_type |
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-721-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Remove the temporary reference. |
6af3bf4
to
6a3b12f
Compare
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at e05eb55. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 17.0
cc https://github.com/APSL 7983
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko @peluko00 please review
#523