[17.0][FIX] fieldservice_stock_request: process all records in _action_confirm #1372
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the _action_confirm method incorrectly returned inside a for loop, causing only the first stock request record to be processed and skipping the rest. This resulted in only one request moving to the 'on process' state, while the others remained stuck in 'submitted', and pickings were not created for all requests.
|
Hi @brian10048, @wolfhall, @max3903, @smangukiya, |
BernatObrador
changed the title
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the _action_confirm method incorrectly returned inside a for loop, causing only the first stock request record to be processed and skipping the rest. This resulted in only one request moving to the 'on process' state, while the others remained stuck in 'submitted', and pickings were not created for all requests.
Now, when confirming a request order, all related stock requests will be properly processed.
cc https://github.com/APSL 8361
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review