[18.0][FIX] website_sale_*: Fix eslint warning #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Tardo, @pilarvargas-tecnativa, |
pilarvargas-tecnativa
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Fix various ESLint warnings in website sale JS modules:
Changes
website_sale_product_attribute_value_filter_existing: Adjust handling of the Odoo-specific module header to satisfy JSDoc / ESLint expectations inwebsite_sale_product_attribute_value_filter_existing_search_desk_tour.esm.js.website_sale_acquirer_confirm_order: Reorder imports so that import * as comes before named imports, complying with the sort-imports rule inwebsite_sale_acquirer_confirm_order_tour.esm.js.website_sale_checkout_skip_payment: Reorder imports so that import * as comes before named imports to satisfy sort-imports inwebsite_sale_checkout_skip_payment_tour.esm.js.website_sale_stock_provisioning_date: Sort named imports alphabetically by module path to fix sort-imports warnings inwebsite_sale_stock_provisioning_date_tour.esm.js.website_sale_require_legal: Reorder imports so that import * as comes before named imports, complying with the sort-imports rule intour.esm.js.website_snippet_product_category: Sort imports alphabetically by module path to satisfy sort-imports infrontend.esm.js.website_sale_secondary_unit: Refactor _onChangeSecondaryUom to avoid reassigning the ev parameter by introducing a local eventToUse variable, keeping the existing fake-event hack while satisfying the no-param-reassign rule inwebsite_sale_secondary_unit.esm.js.