[19.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 19.0 #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot
…nature match the function signature of shop with the original one from website_sale, to avoid potential issues with other modules overwriting the function and passing unexpected parameters
…to check the real functionality of the module TT45590
…ormance improvement - Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
…er extraction in mobile view
…ibute parent container If only the attribute container is hidden, the parent container still occupies a space that is visible in the attribute list. To avoid this, apply the condition to the parent container and hide it completely. TT50704
…ibute container TT51372
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-18.0/e-commerce-18.0-website_sale_product_attribute_value_filter_existing Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_product_attribute_value_filter_existing/
…erformance using ID sets
The overhead of extending the entire "shop()" method is eliminated and
the logic is moved to "_get_additional_extra_shop_values()",
the hook provided by Odoo to add data to the context without duplicating
core code.
In addition, the filtering of unused values is optimized by avoiding
the intersection of recordsets in QWeb ("attr_values_used & v").
Instead, the IDs of used values are precomputed as a set
("attr_values_used_ids") and the templates check "v.id in attr_values_used_ids",
which drastically reduces the cost per iteration.
There was a problem hiding this comment.
Pull request overview
This pull request migrates the website_sale_product_attribute_value_filter_existing module from version 18.0 to 19.0. The module extends the website sale functionality to filter and display only product attribute values that are actually used in product variants, hiding unused attribute values from the filter panel.
Changes:
- Updated module version to 19.0.1.0.0 in the manifest
- Migrated all module files including controllers, templates, tests, and documentation
- Added JavaScript tour tests for verifying attribute filtering behavior
Reviewed changes
Copilot reviewed 19 out of 24 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Updated version to 19.0.1.0.0 and configured assets for test tours |
controllers/main.py |
Controller that computes used attribute values for filtering |
views/templates.xml |
Template overrides to conditionally show attribute values based on usage |
tests/test_website_sale_product_attribute_value_filter_existing.py |
HTTP test cases for validating attribute filtering |
static/src/js/website_sale_product_attribute_value_filter_existing_tour.esm.js |
JavaScript tour for testing basic attribute filtering |
static/src/js/website_sale_product_attribute_value_filter_existing_search_desk_tour.esm.js |
JavaScript tour for testing attribute filtering with search |
i18n/*.po |
Translation files for multiple languages |
| Various documentation files | README, description, configuration, and contributor information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ute_value_filter_existing/tests/test_website_sale_product_attribute_value_filter_existing.py
Outdated
Show resolved
Hide resolved
...g/static/src/js/website_sale_product_attribute_value_filter_existing_search_desk_tour.esm.js
Outdated
Show resolved
Hide resolved
...ttribute_value_filter_existing/i18n/website_sale_product_attribute_value_filter_existing.pot
Outdated
Show resolved
Hide resolved
website_sale_product_attribute_value_filter_existing/i18n/tr.po
Outdated
Show resolved
Hide resolved
website_sale_product_attribute_value_filter_existing/i18n/pt_BR.po
Outdated
Show resolved
Hide resolved
...ute_value_filter_existing/tests/test_website_sale_product_attribute_value_filter_existing.py
Outdated
Show resolved
Hide resolved
ALopez-Adhoc
force-pushed
the
19.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
b307c42 to
cfebc21
Compare
ALopez-Adhoc
force-pushed
the
19.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
cfebc21 to
eac2057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.