Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] crm_security_group: Migration to 18.0 #636

Merged
merged 13 commits into from
Mar 31, 2025
Merged

[18.0][MIG] crm_security_group: Migration to 18.0 #636

merged 13 commits into from
Mar 31, 2025

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 24, 2025 •
edited
Loading

Migration to 18.0

Please @pilarvargas-tecnativa and @carlos-lopez-tecnativa can you review it?

@Tecnativa TT55503

victoralmau and others added 12 commits March 24, 2025 10:31
@victoralmau
[ADD] crm_security_group: Add new category about CRM and create 3 gro…
226b56c 
…ups (Own Documents Only, All Documents and Administrator) to separate Sales and CRM apps
@victoralmau
[IMP] crm_security_group: black, isort, prettier
83c58d5
@victoralmau
[MIG] crm_security_group: Migration to 14.0
93b0ac8 
[UPD] Update crm_security_group.pot

[UPD] README.rst

crm_security_group 14.0.1.0.1
@victoralmau
[MIG] crm_security_group: Migration to 15.0
f1152e3 
TT40356

[UPD] Update crm_security_group.pot

[UPD] README.rst
@victoralmau
[FIX] crm_security_group: Set groups_id in menu items correctly (simi…
0619524 
…lar to v14)

TT40356

crm_security_group 15.0.1.1.0
@luis-ron @victoralmau
Added translation using Weblate (Spanish)
99c2171 
Translated using Weblate (Spanish)

Currently translated at 100.0% (4 of 4 strings)

Translation: crm-15.0/crm-15.0-crm_security_group
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_security_group/es/
@mymage @victoralmau
Added translation using Weblate (Italian)
64ef1fc 
Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: crm-15.0/crm-15.0-crm_security_group
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_security_group/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: crm-15.0/crm-15.0-crm_security_group
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_security_group/it/
@victoralmau
[FIX] crm_security_group: Add ACL from crm.lead.lost to group_crm_own…
13d0839 
…_leads

TT44050

crm_security_group 15.0.1.2.0
@victoralmau
Translated using Weblate (Spanish)
1176b5c 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-15.0/crm-15.0-crm_security_group
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_security_group/es/

[UPD] README.rst
@victoralmau
[MIG] crm_security_group: Migration to 16.0
7da446d 
TT45865

[UPD] Update crm_security_group.pot
@quentinDupont @victoralmau
[16.0][FIX] crm_security_group : crm_team full access for crm_manager
cff1b42 
[BOT] post-merge updates
@victoralmau
[IMP] crm_security_group: pre-commit auto fixes
14beb54
carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Mar 24, 2025
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, and I love having separate groups for Sales and CRM, but I think this module is highly incompatible with many other modules that add new models or menus based on Odoo's standard groups. Examples
OCA/sale-workflow#3429
https://github.com/OCA/crm/tree/18.0/crm_phonecall

@victoralmau victoralmau force-pushed the 18.0-mig-crm_security_group branch from 1530314 to 9bb7999 Compare March 24, 2025 15:36
@victoralmau
Copy link
Member Author

Working fine, and I love having separate groups for Sales and CRM, but I think this module is highly incompatible with many other modules that add new models or menus based on Odoo's standard groups. Examples OCA/sale-workflow#3429 https://github.com/OCA/crm/tree/18.0/crm_phonecall

It is not possible, i.e. if you want to use the groups of this module in crm_phonecall, you would need a module (crm_phonecall_security_group or similar) to extend it.

carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Mar 25, 2025
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the CRM Administrator must be able to see these menus too. What do you think?
image

Demo user
image

@victoralmau victoralmau force-pushed the 18.0-mig-crm_security_group branch from 9bb7999 to 3e5fc87 Compare March 25, 2025 14:12
@victoralmau victoralmau force-pushed the 18.0-mig-crm_security_group branch from 3e5fc87 to 0e82b18 Compare March 25, 2025 15:35
@victoralmau victoralmau force-pushed the 18.0-mig-crm_security_group branch from 0e82b18 to 2564aa8 Compare March 25, 2025 16:46
@victoralmau victoralmau force-pushed the 18.0-mig-crm_security_group branch from 2564aa8 to 4571a9c Compare March 26, 2025 07:18
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Mar 26, 2025
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration crm_security_group
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-636-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 31, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 31, 2025
Open
13 tasks
@OCA-git-bot OCA-git-bot merged commit c8a922e into OCA:18.0 Mar 31, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 38d7067. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-crm_security_group branch March 31, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
8 participants
@victoralmau @OCA-git-bot @pedrobaeza @pilarvargas-tecnativa @carlos-lopez-tecnativa @luis-ron @mymage @quentinDupont