-
-
Notifications
You must be signed in to change notification settings - Fork 724
[MIG] account_invoice_tree_currency: Migration to 18.0 #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[MIG] account_invoice_tree_currency: Migration to 18.0 #2029
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tree_currency Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tree_currency/ca/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/es/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/it/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/hr/
@luisg123v Could you please review |
<field name="inherit_id" ref="account.view_invoice_tree" /> | ||
<field name="arch" type="xml"> | ||
<field name="company_currency_id" position="attributes"> | ||
<attribute name="invisible">0</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
column_invisible
- Prefer Python booleans, or even better, just remove the attribute
<attribute name="invisible">0</attribute> | |
<attribute name="column_invisible" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
7b72439
to
ce3a6c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/ocabot merge nobump |
Sorry @luisg123v you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Hi @moylop260, Could you review/merge, please? Regards, CC @desdelinux |
/ocabot migration account_invoice_tree_currency |
Sorry @luisg123v you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@moylop260 additionally, could you issue the migration command (before merging), please? |
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.