Skip to content

[MIG] account_invoice_tree_currency: Migration to 18.0 #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from

Conversation

isaako34
Copy link

No description provided.

MiquelRForgeFlow and others added 22 commits June 11, 2025 23:54
Currently translated at 100.0% (6 of 6 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tree_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tree_currency/ca/
Currently translated at 100.0% (6 of 6 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tree_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tree_currency/hr/
@isaako34
Copy link
Author

@luisg123v Could you please review

<field name="inherit_id" ref="account.view_invoice_tree" />
<field name="arch" type="xml">
<field name="company_currency_id" position="attributes">
<attribute name="invisible">0</attribute>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • column_invisible
  • Prefer Python booleans, or even better, just remove the attribute
Suggested change
<attribute name="invisible">0</attribute>
<attribute name="column_invisible" />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@isaako34 isaako34 force-pushed the 18.0-mig_account_invoice_tree_currency branch from 7b72439 to ce3a6c1 Compare June 18, 2025 18:45
Copy link

@DantePereyra DantePereyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luisg123v
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @luisg123v you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@luisg123v
Copy link
Contributor

Hi @moylop260,

Could you review/merge, please?

Regards,

CC @desdelinux

@luisg123v
Copy link
Contributor

/ocabot migration account_invoice_tree_currency

@OCA-git-bot
Copy link
Contributor

Sorry @luisg123v you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@luisg123v
Copy link
Contributor

@moylop260 additionally, could you issue the migration command (before merging), please?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.