Adding the OBI import module #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
commented
Feb 10, 2025
| query --update ../sparql/inject-subset-declaration.ru --update ../sparql/inject-synonymtype-declaration.ru \ | ||
| remove --base-iri $(OBOBASE)/OBI --axioms external --preserve-structure false --trim false \ | ||
| remove $(patsubst %, --term %, $(ANNOTATION_PROPERTIES)) --term rdfs:label --term IAO:0000115 -T $(IMPORTDIR)/obi_terms_combined.txt --select complement --select "classes individuals annotation-properties" \ | ||
| $(ANNOTATE_CONVERT_FILE); fi |
There was a problem hiding this comment.
All of this is custom, feel free to change to whatever why you want!
|
Not anymore needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamesaoverton the extraction code in cob.Makefile is a draft proposal for you to check and rework the way that you want.
Right now, the seed is extracted using the default ODK strategy, which is looking at all of COB, finding any mentions of OBI terms and trying to extract them. If you want another behaviour (like extracting from that table as you suggested), we will have to overwrite this make target:
imports/obi_terms_combined.txt.Let me know how you would like to proceed!