Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct Duration (pre-sign url Expiry edit from cos-get node #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

burtonboucher
Copy link
Contributor

Corrects crash when changing default of 900 seconds:
8 Feb 18:46:24 - [red] Uncaught Exception:
28 Feb 18:46:24 - InvalidParameterException: The expiration must be a number, received string

2 changes required to fix:
cos.js line 73 to:
var expiry = parseInt(node.geturlExpiry);

cos.html line 55 to:

What changed:

cos.html geturlExpiry was set to type "number". Any change in node from UI is read as text.
cos.js Set Expiry to integer using ParseInt(). this ensures any entry for Expiry will be an integer as expected.

correct issue when editing "Duration (seconds)" in cos-get node. Any change to default of 900 seconds would cause node-RED to crash:
8 Feb 18:46:24 - [red] Uncaught Exception:
28 Feb 18:46:24 - InvalidParameterException: The expiration must be a number, received string

This issue has been corrected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant