Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation support for buttons #2

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from

Conversation

Technosword
Copy link

Don't merge quite yet as I am still testing it. This update adds support to callback buttons right within the class where you want them defined. It is pretty cool if I do say so myself!

@Nyvil
Copy link
Owner

Nyvil commented Jan 26, 2022

Hello Technosword!

I'm thankful for all your time and efforts!
However, the reason I didn't add callback button support is because of the number of exploits there have been (for example button id spoofing), and I'm not sure that they have been resolved yet. That said if you wish to maybe not push it to stable, but to another branch, called buttons or something, with a note in readme or something that there is said branch, I'll gladly accept your PR (after you give me the go)

Best Regards,
Nyvil

@Nyvil Nyvil self-requested a review January 26, 2022 19:06
@Nyvil Nyvil marked this pull request as ready for review January 26, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants