-
Notifications
You must be signed in to change notification settings - Fork 5
[DO NOT MERGE] JOSS Paper Draft #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 7 7
Lines 1546 1546
=======================================
Hits 1518 1518
Misses 28 28 ☔ View full report in Codecov by Sentry. |
I added bibliography information for all the papers that I could think of that describe or analyze the currently implemented schemes. Do we also want to make reference to schemes that could be implemented in the future? What's the purpose of the section "Related research and software"? Do want to give a general overview or do we want to describe exactly in which paper which implemented method can be found? |
Thanks!
We should only describe what kind of schemes are implemented - plans may change and we may not implement other methods we could list...
This section should contain
|
Co-authored-by: Joshua Lampert <[email protected]>
3cbf5de
to
888df07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the draft! I had a brief look and left some comments below.
Co-authored-by: Joshua Lampert <[email protected]>
Pull Request Test Coverage Report for Build 14623225132Details
💛 - Coveralls |
Co-authored-by: Hendrik Ranocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some final comments below.
Co-authored-by: Joshua Lampert <[email protected]>
I added tags and set the date to tomorrow. @ranocha @JoshuaLampert if you agree with the tags, I will submit tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I have only two final minor comments/suggestions.
Co-authored-by: Joshua Lampert <[email protected]>
Great, thanks a lot! I am fine submitting the paper 👍 |
CI is failing again on macOS inside a work-precision fixed: Test Failed at /Users/runner/work/PositiveIntegrators.jl/PositiveIntegrators.jl/test/runtests.jl:2594
Expression: maximum((v .- m1) ./ m1) < 1.5
Evaluated: 1.8971724926437623 < 1.5 But I don't see why this happens, since the allowed tolerance for macOS should be |
I guess we should delete this line: PositiveIntegrators.jl/test/runtests.jl Line 2594 in fad4655
because it is doubled in PositiveIntegrators.jl/test/runtests.jl Line 2601 in fad4655
with the platform dependent tolerance. |
Thanks! |
Now building the docs fails. To github.com:NumericalMathematics/PositiveIntegrators.jl
! [rejected] HEAD -> gh-pages (fetch first)
error: failed to push some refs to 'github.com:NumericalMathematics/PositiveIntegrators.jl'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details. |
Where do you see this error? It is likely just a race condition from two CI jobs trying to push changes at the same time. We can submit the paper anyway |
I restarted CI yesterday evening. This error was just spurious. |
DO NOT MERGE THIS PR
We can use this PR to check and discuss the paper draft. The PR can be closed when the JOSS paper is finished. The branch
paper-2025-joss
must be kept around forever.You can download the PDF of the paper draft from the GitHub action
Build JOSS paper draft PDF / JOSS Paper Draft (pull_request)
below.Summary
on the left