Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Startup Server Feedback and Port In Use Detection #592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

crhultay
Copy link
Contributor

Startup with Server Feedback
image

Startup with Port In Use Error
image

This will address @voipmeister's request per #547.

@NuSkooler
Copy link
Owner

@crhultay This is great work, thank you!

One note on the color: Please use the existing pipe code based system already in use in code such as in connect.js via pipeWrite()

@crhultay
Copy link
Contributor Author

crhultay commented Feb 25, 2025

@crhultay This is great work, thank you!

One note on the color: Please use the existing pipe code based system already in use in code such as in connect.js via pipeWrite()

pipeWrite() is an extension of ClientTerminal; however the code I have written is to console.{level}.

Looking inside of client_term is a call to renegateToAnsi().

Do we need to write a new extension to console.prototypes? (not entirely sure how to do this in JS).

Edit: If you show me how I could initialise a ClientTerminal that would be used by the console when Enigma1/2 loads -- this opens up some interesting possibilities... like the callawait screen.

@NuSkooler
Copy link
Owner

@crhultay Sorry, yes just use renegadeToAnsi() and process.stdout(). Note however, that some may be running this in environments where ANSI is not suitable, or capturing in logs -- thus, you'll want to respect NO_COLOR and/or a --no-color type CLI option, which makes this more complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants