Skip to content

Make the pack command available in classic csproj, reduce .NET SDK size by merging pack & restore functionality #14401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jul 3, 2025

Design for #14046

Rendered

cc @zivkan

@nkolev92 nkolev92 requested a review from a team as a code owner July 3, 2025 21:06
@nkolev92 nkolev92 mentioned this pull request Jul 3, 2025
Copy link
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm interested what our partner teams will think, especially about the risk of breaking changes.

@nkolev92
Copy link
Member Author

nkolev92 commented Jul 7, 2025

@dsplaisted @jeffkl @rainersigwald @baronfel
Thoughts?

@jeffkl jeffkl self-requested a review July 8, 2025 22:10
jeffkl
jeffkl previously approved these changes Jul 15, 2025
zivkan
zivkan previously approved these changes Jul 15, 2025
dsplaisted
dsplaisted previously approved these changes Jul 15, 2025
@nkolev92 nkolev92 dismissed stale reviews from dsplaisted, zivkan, and jeffkl via cfef4a7 July 16, 2025 21:39
@nkolev92
Copy link
Member Author

fyi @aortiz-msft

This change is:

  • A functionality win for anyone that still has to use old style csproj
  • A tech debt win for our build/testing, since we can finally drop the .NET Standard 2.0 leg of our builds.
  • A tech debt win reducing the size of the .NET SDK.

@nkolev92
Copy link
Member Author

I'll merge this PR as the design has been signed-off.
We can still decided how/when to roll it out.

@nkolev92 nkolev92 merged commit 62af14f into dev Jul 18, 2025
1 check passed
@nkolev92 nkolev92 deleted the dev-nkolev92-consolidatePackaRestore branch July 18, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants