Custom File Path to store database file for Android #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the user with the ability to pass in a file path instead of the database name only and creates the *.db file under a 'databases' sub-folder under the provided path.
radex
reviewed
Jan 27, 2021
native/android/src/main/java/com/nozbe/watermelondb/Database.kt
Outdated
Show resolved
Hide resolved
|
@rozPierog can you review in a spare moment? |
added 2 commits
January 27, 2021 14:53
…hlng1080/WatermelonDB into feature_android_file_path
|
@rozPierog ⬆️ |
rozPierog
requested changes
Mar 25, 2021
native/android/src/main/java/com/nozbe/watermelondb/Database.kt
Outdated
Show resolved
Hide resolved
update from main repo
* feat(TS): add unsafeExecute method
* feat(TS): add sql migration step
* [loki] improved diagnostic
* add {sqlString:} option to sqliteAdapter.unsafeExecute
* v0.24.1-2
* v0.24.1-3
* makeDispatcher error diagnostics
* v0.24.1-4
* v0.24.1-5
Co-authored-by: Mickael Lecoq <[email protected]>
Co-authored-by: Radek Pietruszewski <[email protected]>
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@rozPierog kindly review this PR :) |
avinashlng1080
changed the title
darrencrossley
added a commit
to agrantis/WatermelonDB
that referenced
this pull request
Feb 6, 2024
darrencrossley
added a commit
to agrantis/WatermelonDB
that referenced
this pull request
Feb 6, 2024
darrencrossley
added a commit
to agrantis/WatermelonDB
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the user with the ability to pass in a file path instead of the database name only and creates the *.db file under a 'databases' sub-folder under the provided path.