Fix WMDatabaseBridge compatibility with Bridgeless architecture #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates WMDatabaseBridge to use getJSMessageQueueThread() instead of getCatalystInstance().getReactQueueConfiguration().getJSQueueThread(). The change addresses a NullPointerException when running on the Bridgeless architecture, which no longer supports CatalystInstance.
This change replaces getJSMessageQueueThread().runOnQueue() with runOnJSQueueThread() to improve readability and consistency with updated APIs. Co-authored-by: @dppo <[email protected]>
|
Can you check and merge this @radex please. I need this fix. Don't want to go for patching for now. This is any way a good fix as now most of the react native app will use 0.76. so please merge it |
|
I can confirm, this patch works very well with the new architecture. Please merge it! @radex |
|
Why is there no reaction here? It's an important bugfix? |
|
I have mailed him related to this. I hope he responds and take care of this thing. I am blocked unless this feature is added 🥲 |
|
I'm surprised that no one cares about this. At least an answer would be nice. |
|
merged, pushed a 0.28.0-2 pre-release to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following
NullPointerExceptionthat occurs on app reload in the new architecture:This issue arises because the new Bridgeless architecture does not support
CatalystInstance, as described in the React Native source code.This change updates
WMDatabaseBridgeto userunOnJSQueueThread()instead ofgetCatalystInstance().getReactQueueConfiguration().getJSQueueThread().runOnQueue(), ensuring compatibility with the Bridgeless architecture.