-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encrypted SQLCipher WatermelonDB JSI #1635
base: master
Are you sure you want to change the base?
Conversation
Changes: - add a flag if using encrypted DB - install openssl if using encrypted db
- add pathes to cipher amalgamation based on the flags. - add openSSL lib
@radex I can not seem to run the ios/android tests properly, any chance you help me with it? |
Hey guys, Thanks for your great work on this, and thanks for the great library Is this PR still alive? Is there still interest in Nozbe in adding encryption to the DB? I was able to make something work based on this PR #907, but of course, it does not support JSI. @ororsatti, does your PR work? I just did a test, but it seems that the DB is not getting encrypted (Android). |
I'm using it in several production apps, so yep. |
@ororsatti thank you very much for your valuable help on this. Indeed your PR works as expected. @radex would it be preferable to make it into a separate adapter? Or just as an option to the base SQLite adapter as is with this PR? |
I don't think making it an adapter is the right decision. |
You can think about it like it's a car. |
ideally i'd like to avoid adding to the non-JSI version since its going to be less and less supported as we progress with JSI in RN.
TODO: