Skip to content

Add @AddUnusedParam #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Add @AddUnusedParam #7

merged 6 commits into from
Jul 8, 2024

Conversation

NotStirred
Copy link
Owner

@NotStirred NotStirred commented Jul 7, 2024

Need to add more tests before merging.
Mainly to make sure that adding the local variable doesn't break anything

@NotStirred NotStirred added the enhancement New feature or request label Jul 7, 2024
Currently only appends parameters to the end of the signature
but could be extended in the future to inserting at a
specific index.
@NotStirred NotStirred force-pushed the feature/add_unused_param branch from e2fe406 to d2dbd9e Compare July 7, 2024 00:51
@NotStirred NotStirred linked an issue Jul 7, 2024 that may be closed by this pull request
@NotStirred NotStirred force-pushed the feature/add_unused_param branch from 2d6b51d to 423003d Compare July 7, 2024 22:40
@NotStirred
Copy link
Owner Author

Only thing left is to rewrite the annotation api to have the @AddUnusedParam annotation be inline in the transform method definition, rather than specified above

@NotStirred NotStirred force-pushed the feature/add_unused_param branch from 423003d to a676855 Compare July 7, 2024 22:50
@NotStirred NotStirred marked this pull request as ready for review July 8, 2024 19:40
@NotStirred NotStirred merged commit d1b2ad8 into master Jul 8, 2024
1 check passed
@NotStirred NotStirred deleted the feature/add_unused_param branch July 8, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding unused parameters to transformed method signatures
1 participant