Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update? #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update? #15

wants to merge 3 commits into from

Conversation

ILikeW
Copy link

@ILikeW ILikeW commented May 28, 2024

No description provided.

Added SIGINT handler
Let regular guild members submit images for the rotation
updated to support code
@ILikeW
Copy link
Author

ILikeW commented May 28, 2024

should be good though you should review

Copy link
Owner

@NotNorom NotNorom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey so this is a nice idea but I cannot currently merge this because of the things I mentioned in the code.

I do like the idea of having users submit an image and them being approved! With the changes introduced since the v0.5.1 tag this will be possible by having a discord channel full of approved images and a discord channel full of image requests :)

let guild_id = ctx.guild_id().ok_or(CommandErr::GuildOnly)?;

// Define the private channel ID where submissions will be sent
let private_channel_id = ChannelId(123456789012345678); // Replace with your private channel ID
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bot is designed to run in multiple guilds so a hard coded value at this point would not work :<

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes forgot about that, I'll work on changing it

Comment on lines +56 to +57
// Add the approved image to the rotation (implement your own storage for approved images)
// For simplicity, we'll just log it here
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently do not plan on storing the images themselves anywhere and instead just using the images hosted on discord.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah

Comment on lines +57 to +64
// Spawn a task to handle SIGINT
let shard_manager = client.shard_manager.clone();
tokio::spawn(async move {
signal::ctrl_c().await.expect("Failed to listen for ctrl_c");
shard_manager.lock().await.shutdown_all().await;
info!("Received SIGINT, shutting down.");
});

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like and and I want to have it as you can see from #14

@NotNorom
Copy link
Owner

If you want, we can talk about what you need from the bot in my support discord: https://discord.gg/MMJFtCtYPP

Maybe we can figure stuff out together :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants