Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add range task #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add range task #3

wants to merge 3 commits into from

Conversation

SamuelJanas
Copy link

Added a RangeTask.

This task filters notes_df that starts between start_sec and end_sec.

I'm not entirely sure as to the use of two <PARAMETER_x> tokens. I was thinking about some other approaches:

  • <PARAMETER_x_y> for range in one token.
  • enclose notes tokens in <RANGE_START> <RANGE_END>. This would be easier to combine with other tasks. to potentially create top_line_in_range task without explicitly defining it.
  • <PARAMETER_x> but pre-determine the end after start + ~5 seconds. The x would signal the start time.

dashboard:

image

Comment on lines 21 to 29
- class: RangeMasking
param_range:
- start_sec: 0
end_sec: 5
- start_sec: 5
end_sec: 10
- start_sec: 0
end_sec: 10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given results of the experiments so far, I'd say that 5 and 10s interval are way too long. We can still include them, but I'd look for a way to have this type of task mask 1-5s of music with many possible starting points. I think this could either be achieved by a pretty large config with many combinations, or another approach to integration with the "PianoDataset" we use for training 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it a look and see what works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants