Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PianoRoll subpage update #13

Merged
merged 25 commits into from
Oct 8, 2024
Merged

Conversation

Fermatka
Copy link
Collaborator

@Fermatka Fermatka commented Jul 29, 2024

Tasks

  • Subpage update: task link
  • Correct bad spacing in mobile/Contact: task link
  • Add new logo
  • Correct darkTheme

@Fermatka Fermatka self-assigned this Jul 29, 2024
@roszcz
Copy link
Member

roszcz commented Sep 6, 2024

In light mode, I don't see the letters:

image image

@Fermatka
Copy link
Collaborator Author

Fermatka commented Sep 9, 2024

@roszcz should be ok now:
Zrzut ekranu 2024-09-09 110523
Zrzut ekranu 2024-09-09 110529

@roszcz
Copy link
Member

roszcz commented Sep 9, 2024

Thanks! Can you also update favicon to the new black/white logo. Currently it shows the default next js icon:

image

@Fermatka
Copy link
Collaborator Author

Fermatka commented Sep 9, 2024 via email

Copy link

@TheMankel TheMankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the svg element instead of the img element for the logo and just change the text color when the theme changes instead of loading a new image, but this is not a mistake 👌

Two things:

  • Should this section have #f5f3f5 background color?

image

Or should it be darker like in Figma?

image

  • There is something wrong with the theme toggle button when it detects the system's preferred theme - I prefer a dark theme and the app detects this. After the first click the theme does not change to the opposite one. Further clicks work properly
Theme.mp4

@roszcz roszcz merged commit 871af3d into develop Oct 8, 2024
1 check passed
@roszcz roszcz deleted the PROLL-235/PianoRoll-subpage-refactor branch October 8, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants