Skip to content

Remake get started #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remake get started #1091

wants to merge 4 commits into from

Conversation

rma-rudder
Copy link
Contributor

No description provided.

@rma-rudder rma-rudder requested review from amousset and ncharles and removed request for amousset March 31, 2025 15:53
@rma-rudder rma-rudder self-assigned this Mar 31, 2025
@rma-rudder rma-rudder requested a review from m-bouissou March 31, 2025 15:54
Copy link
Contributor

@m-bouissou m-bouissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few suggestions on the first parts of the tutorial, and also found some small issues

Comment on lines 53 to 57
Now you can go to our node details by using the quick search filter, and searching for *node*
(it's our node's hostname).
Let's look at our node compliance in details. Click on:

Go to the *Compliance reports* tab. You will see the applied policy and the current compliance
regarding it. If you click on a line it will unfold until you get to the actual applied
component.
. *Nodes* menu
. the node hostname *server*
. the *Compliance* tab
. unfold in clicking on *Global configuration for all nodes* in the screen lower part
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for using the menu.
But I find the steps so concise that it overall looks a bit harsh.
For example we could explain what we will do before guiding the user :

For that, first open the node details page and navigate in the compliance tree : 
* <steps ...>

@@ -6,61 +6,60 @@

In this section you will:

* Use policy building blocks in the builder UI
* Use Rudder's technique editor building blocks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Use Rudder's technique editor building blocks
* Use building blocks within the technique editor in Rudder

Comment on lines 27 to 29
We can now name our technique: *Demo user*, and add a small description for documentation:
We can now name our technique: _Demo user_, and add a small description for documentation:

image::./new.png["New technique form", align="center"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image is no longer added, and it looks intentional because the previous image already explains it. So, the : should be replaced by .

Comment on lines 38 to 40
Let's start using methods to build a technique. Click on:

image::./demo.png["demo user", align="center"]
* the *Add* button to add methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first Add button is not easy to find without indicating where methods should be.
Maybe instead of Click on :

The _Methods_ section at the bottom of the page is empty. To add methods : 
* click on the *Add* button
* <other steps ...>


* click on *Add methods* in the lower left of the technique details, to display the list of available methods,
* navigate to the *User* category.
* add a user description, with the xref:reference:reference:generic_methods.adoc#_user_fullname[User fullname method]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this links looks broken due to the generic methods doc structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not broken on my laptop when i test it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it is actually broken, it does not lead to a 404 page, but the anchor #_user_fullname is not correctly resolved so on the page I need to search for the "User fullname method".
The issue looks like it was already there before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the doc has just been removed in #1096, instead it should point to https://docs.rudder.io/techniques/8.3/user_fullname.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yes i understand !


And go to the bottom of the page, click on *Global configuration for all nodes*
(to apply it everywhere, we will see how it works later).
. click on *Target rules*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. click on *Target rules*
. click on the *Target rules* tab

And go to the bottom of the page, click on *Global configuration for all nodes*
(to apply it everywhere, we will see how it works later).
. click on *Target rules*
. choose *Global configuration for all nodes*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. choose *Global configuration for all nodes*
. check *Global configuration for all nodes*

Comment on lines 29 to 28
header bar. Here you can search for any Rudder item (there is even a small query language!).
Let's change the policy mode. Click on:

image::./quicksearch.png["Quicksearch field", align="center"]
. menu *Directives*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the policy mode of the directive by updating it. Navigate to the directive page by clicking on : 
* *Directives* in the menu


And click on your directive to go to its configuration page. Now change policy mode to
default, and save.
Go back to the demo user directive. You can use the Directive page, or use the quick search field, in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Go back to the demo user directive. You can use the Directive page, or use the quick search field, in the
Go back to the _demo_ user directive. You can use the Directive page, or use the quick search field, in the

----
rudder agent update
rudder agent run
----

You will see the actual modification happening, with a "repaired" state, and the demo user now exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You will see the actual modification happening, with a "repaired" state, and the demo user now exists
You will see the actual modification happening, with a "repaired" state, and the _demo_ user now exists

@rma-rudder
Copy link
Contributor Author

@clarktsiory Thanks for the review. I commited to resolve your comments. There is only the broken link. It is not broken when I test it. Were you saying that because you tested it ? Or just the look of it ?

@@ -15,8 +15,7 @@ The rest of the tutorial assumes you are
using this environment (you can also setup your own,
you will only have to substitute hostnames/IP addresses when necessary).

This installation method is cross-platform, and you can use it on Linux, Microsoft Windows, Mac OS X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the mention of macOS here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants