Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full file path in the MztabWriter run map instead of just the file name. #386

Open
Lilferrit opened this issue Oct 4, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Lilferrit
Copy link
Contributor

Lilferrit commented Oct 4, 2024

The current implementation of MztabWriter on the dev_latest_depthcharge branch only uses the file name to index peak files instead of the full path. This will lead to incorrect behavior when sequencing spectra from two peak files that have different paths but have the same filename, e.g. foo/spectra.mgf and bar/spectra.mgf. This should be implemented after the depthcharge spectrum datasets are updated to include the full file path for each spectrum. This can be implemented by simply changing the following line in MztabWriter.set_ms_run:

self._run_map[Path(filename).name] = i
@Lilferrit Lilferrit added bug Something isn't working enhancement New feature or request labels Oct 4, 2024
@Lilferrit Lilferrit added this to the Depthcharge v0.4 milestone Oct 4, 2024
@Lilferrit
Copy link
Contributor Author

Related to wfondrie/depthcharge#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant