Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate freq parameter with data in fill_gaps #154

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

AlexMilanor
Copy link
Contributor

Add frequency validation to the freq parameter of the fill_gaps function, so that any mismatch between the time column and frequency is caught earlier.

PR for issue #153.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2025

CLA assistant check
All committers have signed the CLA.

@jmoralez jmoralez added enhancement New feature or request fix bug fix and removed enhancement New feature or request labels Feb 20, 2025
Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Appreciate the thorough tests

@jmoralez jmoralez merged commit 24c1076 into Nixtla:main Feb 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill_gaps function gives uninformative Exception in case of frequency error
3 participants