Skip to content

Conversation

@erichelgeson
Copy link
Contributor

@erichelgeson erichelgeson commented Mar 31, 2025

https://github.com/Netatalk/netatalk/releases/tag/netatalk-4-2-0

Fixes #389617

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 31, 2025
Comment on lines +18 to +26
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the standard CUPS libdir not writable on Nix? Or is Nix storing CUPS backends in a different dir?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. Nix/NixOS is not FHS compliant. Everything is /nix/store-centric.

@kfiz
Copy link
Contributor

kfiz commented Apr 1, 2025

This PR works for me and resolves #389617. Thanks.

@erichelgeson erichelgeson marked this pull request as ready for review April 1, 2025 13:06
@nix-owners nix-owners bot requested a review from jcumming April 1, 2025 13:14
@Lynnaut
Copy link
Contributor

Lynnaut commented Apr 9, 2025

@FliegendeWurst Can we get this merged as well? The current 4.1.2 in unstable makes it pretty much unusable as can be seen by the issue in the comment above.

@FliegendeWurst FliegendeWurst merged commit 99fe4a8 into NixOS:master Apr 9, 2025
63 checks passed
@erichelgeson erichelgeson deleted the eric/netatalk420 branch April 9, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

netatalk: cannot create afp files

5 participants