Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile: 0.15.7 → 0.15.8 #364873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sile: 0.15.7 → 0.15.8 #364873

wants to merge 1 commit into from

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Dec 13, 2024

This should be a simple version bump, but upstream changes do affect the library modules build that was broken before on Darwine. This PR removes the broken flag but we should actually wait for CI to finish and confirm it works this time to avoid a repeat of the broken master scenario from the last bump.

c.f. #361005

c.f. Upstream release notes and checklist

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alerque
Copy link
Contributor Author

alerque commented Dec 13, 2024

@doronbehar See also my comment here, I'm not convinced fetchCargoTarball has realy been taught not to try to run ./configure yet.

@ofborg ofborg bot requested a review from doronbehar December 14, 2024 03:13
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 14, 2024
@doronbehar
Copy link
Contributor

Still there's an error on Darwin:

       > /nix/store/bp2yamylj44byk4flc9czdsf91y42pyv-coreutils-9.5/bin/install -c target/x86_64-apple-darwin/release/librusile.so rusile.so
       > install: cannot stat 'target/x86_64-apple-darwin/release/librusile.so': No such file or directory
       > make[2]: *** [Makefile:1953: rusile.so] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-sile-0.15.8.drv-0/sile-0.15.8'
       > make[1]: *** [Makefile:1189: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-sile-0.15.8.drv-0/sile-0.15.8'
       > make: *** [Makefile:773: all] Error 2
       For full logs, run 'nix log /nix/store/77ndplr9vr8wwyw4x36jc46rxflak2mg-sile-0.15.8.drv'.

@alerque
Copy link
Contributor Author

alerque commented Dec 14, 2024

Still there's an error on Darwin:

Ya she's broke.

I've been debugging this CI runs half the day and still haven't nailed it down. I do know I can build it just fine from source myself on macOS with Homebrew supplied dependencies, but building the Homebrew formula is throwing this same error. I think the difference is it builds from Git using autotools from scratch, but not from the release source tarball. Inspecting the config status after ./configure shows it set the right vars for *.dylib support, but somehow it's using generated code from the system that built the source tarball instead of the configure-time discovered values.

I'm still working on it. We can either put this on hold or mark it as still broken on Darwin.

@doronbehar
Copy link
Contributor

but somehow it's using generated code from the system that built the source tarball instead of the configure-time discovered values.

I suspect that something is not done correct when the release tarball is generated on a Linux machine, and then it is being extracted on a Darwin machine.

I'm still working on it. We can either put this on hold or mark it as still broken on Darwin.

That sounds like a hard issue to debug. I'd still mark it as broken for now, and you can keep debugging this via a private nixpkgs checkout on your macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants