-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sile: 0.15.7 → 0.15.8 #364873
base: master
Are you sure you want to change the base?
sile: 0.15.7 → 0.15.8 #364873
Conversation
@doronbehar See also my comment here, I'm not convinced |
Still there's an error on Darwin:
|
Ya she's broke. I've been debugging this CI runs half the day and still haven't nailed it down. I do know I can build it just fine from source myself on macOS with Homebrew supplied dependencies, but building the Homebrew formula is throwing this same error. I think the difference is it builds from Git using autotools from scratch, but not from the release source tarball. Inspecting the config status after I'm still working on it. We can either put this on hold or mark it as still broken on Darwin. |
I suspect that something is not done correct when the release tarball is generated on a Linux machine, and then it is being extracted on a Darwin machine.
That sounds like a hard issue to debug. I'd still mark it as broken for now, and you can keep debugging this via a private nixpkgs checkout on your macOS. |
This should be a simple version bump, but upstream changes do affect the library modules build that was broken before on Darwine. This PR removes the broken flag but we should actually wait for CI to finish and confirm it works this time to avoid a repeat of the broken master scenario from the last bump.
c.f. #361005
c.f. Upstream release notes and checklist
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.