Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Remove obsolete workaround for fetchCargoTarball #362570

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Dec 6, 2024

Now that #360540 has merged, these workarounds should not be necessary.

Additionally this marks the sile deivation as broken on darwin. The issue is known upstream and it could be patched here with some RUSTFLAGS and a small patch, but since the next release shouldn't be too far off with this fixed upstream it is probably okay to just wait it out.

Closes #361005

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 6, 2024
@Aleksanaa Aleksanaa changed the title Remove obsolete workaround for fetchCargoTarball treewide: Remove obsolete workaround for fetchCargoTarball Dec 7, 2024
@Aleksanaa Aleksanaa merged commit c77b49d into NixOS:master Dec 7, 2024
22 of 25 checks passed
@alerque alerque deleted the drop-cargo-workaround branch December 7, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: sile, sile.dev sile.doc sile.man on darwin since 0.15.6
2 participants