Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile: 0.15.5 → 0.15.6 #355895

Merged
merged 1 commit into from
Nov 18, 2024
Merged

sile: 0.15.5 → 0.15.6 #355895

merged 1 commit into from
Nov 18, 2024

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Nov 14, 2024

Release notes: https://github.com/sile-typesetter/sile/releases/tag/v0.15.6

Nothing in this release should need any build changes relevant to Nix. There were build system changes to accomodate Homebrew's weird pseudo-system vendoring, but that shouldn't affect this derivation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from doronbehar November 14, 2024 23:09
@doronbehar doronbehar merged commit 2c8cc44 into NixOS:master Nov 18, 2024
32 of 33 checks passed
@doronbehar doronbehar deleted the sile-0156 branch November 18, 2024 10:18
@kachick kachick mentioned this pull request Dec 2, 2024
13 tasks
@kachick
Copy link
Member

kachick commented Dec 2, 2024

@alerque Build on darwin looks failed since updating to this version. Should I create the build failure issue or setting meta.broken?

#360969 (comment)

https://hydra.nixos.org/build/278406114
https://hydra.nixos.org/build/279510156

@kachick kachick mentioned this pull request Dec 2, 2024
13 tasks
@alerque
Copy link
Contributor Author

alerque commented Dec 2, 2024

@kachick Lets get a build failure issue, that is expected to work and the failure probably has to do with a workaround we removed in the previous version bump, but we should look into it and get it fixed.

@kachick
Copy link
Member

kachick commented Dec 2, 2024

Sure! Posted the issue in #361005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants