dbeaver: remove package #311888
Merged
dbeaver: remove package #311888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naxdy
force-pushed
the
work/remove-dbeaver
branch
3 times, most recently
from
a148835
to
c1aa991
Compare
RaghavSood
approved these changes
May 15, 2024
14 tasks
gepbird
suggested changes
May 16, 2024
Naxdy
force-pushed
the
work/remove-dbeaver
branch
from
c1aa991
to
4ebb697
Compare
gepbird
approved these changes
May 16, 2024
tomcur
added a commit
to tomcur/nixos-configuration
that referenced
this pull request
May 22, 2024
Replace dbeaver with dbeaver-bin. See: - NixOS/nixpkgs#311888 - NixOS/nixpkgs#311968
|
Painful but understandable. Thank you. |
|
@hraban |
|
I am on darwin so unfortunately that doesn't work for me. I've pinned the last nixpkgs where it was available. Thanks though! |
|
@hraban dbeaver has prebuild .dmg files for aarch64-darwin and x86_64-darwin: https://github.com/dbeaver/dbeaver/releases/tag/24.0.5. Feel free to add support for it in dbeaver-bin :) |
One day ;) when the current pin breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The current version of DBeaver is severely outdated, released in Oct. 2022: https://dbeaver.io/2022/10/10/dbeaver-22-2-2/
Updating DBeaver is non-trivial, so far there have been two incomplete/failed attempts:
The reason for this is that DBeaver does not properly pin its dependencies, and it is not possible for us to do this through simple patches of its source, because subdependencies are also affected by the same problem. We would need something like mvn2nix in
nixpkgsto manually pin the entire dependency tree and perform an offline install from a repo we build ourselves (similar to howprefetch-npm-depsandyarn2nixdo it).However, this option does not exist for maven deps in
nixpkgscurrently, so the only viable alternative left is to remove this version of DBeaver, and perhaps in the future, replace it with a-binpackage that we patch or wrap in an FHSEnv.Lastly, the current version of DBeaver in
nixpkgsalso fails to build, and is only available through binary cache, so besides being severely outdated, the package is also currently broken.fixes #267405
Closes #232348
Closes #249293
Related tracking issue: #278518
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.