datatrove: init at 0.2.0 #311867
Open
datatrove: init at 0.2.0 #311867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelroses
reviewed
May 15, 2024
|
You should also squash you commits into one commit called |
|
Shouldn't be this possible automatically? EDIT: Done! |
luftmensch-luftmensch
force-pushed
the
datatrove_0.2.0
branch
from
a4a5b54
to
0fd5484
Compare
isabelroses
approved these changes
May 15, 2024
Perhaps, I've always just squashed and force pushed. This probably depends on the reviews perspective. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1641 |
Gerg-L
approved these changes
May 22, 2024
Gerg-L
reviewed
May 22, 2024
|
Result of 2 packages built:
|
luftmensch-luftmensch
force-pushed
the
datatrove_0.2.0
branch
from
0fd5484
to
9404522
Compare
There was a problem hiding this comment.
Please run the tests with pytestCheckHook https://github.com/huggingface/datatrove/tree/main/tests
luftmensch-luftmensch
force-pushed
the
datatrove_0.2.0
branch
from
9404522
to
cbf6357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #311862
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.