Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR introduces a new package
mysql-backup
and a nixos moduleservices.databacker-mysql-backup
to configure it.A few notes:
mysql-backup
to enable it to connect over the local unix domain socket.Module name conflict
There already exists a
services.mysqlBackup
module that is a small collection of bash scripts. This PR does not have anything to do with that module.But then why add this module if
services.mysqlBackup
already exists?I think this comparison table speaks for itself:
services.mysqlBackup
services.databacker-mysql-backup
(this PR)Also, I am not happy with the name
services.databacker-mysql-backup
but I thought thatservices.mysql-backup
, while available was too close to the existingservices.mysqlBackup
. I'm open to better name suggestions, but please no bike shedding.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.