Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2: use llvmPackages_9.stdenv #144115

Merged
merged 1 commit into from
Nov 29, 2021
Merged

edk2: use llvmPackages_9.stdenv #144115

merged 1 commit into from
Nov 29, 2021

Conversation

pennae
Copy link
Contributor

@pennae pennae commented Nov 1, 2021

Motivation for this change

trying to figure out why #143820 failed in ofborg led to edk2, which uses a stdenv where stdenv.cc is a list. that doesn't look right.

note: can't test on darwin, which is where that stdenv would be used. :/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pennae pennae changed the title edk2: use clang9Stdenv edk2: use llvmPackages_9.stdenv Nov 1, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 1, 2021
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2021
stdenv.cc being a list does not seem to be such a good thing.
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 26, 2021
@SuperSandro2000 SuperSandro2000 merged commit bf14c1f into NixOS:master Nov 29, 2021
@pennae pennae deleted the edk2-stdenv branch December 7, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants