Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raspberry-pi.4.leds: enable overlays-dtmerge + fix target names #1290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 28, 2024

Description of changes

currently the overlays are not applied.

and somehow it got renamed... compare kernel:

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@Stunkymonkey Stunkymonkey force-pushed the fix-raspberry-leds-disable branch from 7d16508 to 945831c Compare December 28, 2024 13:00
@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 28, 2024 13:00
@Stunkymonkey Stunkymonkey changed the title WIP: raspberry-pi.4.leds: enable overlays-dtmerge raspberry-pi.4.leds: enable overlays-dtmerge + fix target names Dec 28, 2024
@Stunkymonkey Stunkymonkey requested a review from Mic92 December 28, 2024 13:01
@Stunkymonkey
Copy link
Contributor Author

i am going to add a condition so it can be used by everybody

@Stunkymonkey Stunkymonkey marked this pull request as draft January 6, 2025 14:51
@Stunkymonkey Stunkymonkey force-pushed the fix-raspberry-leds-disable branch from 945831c to 202b2a4 Compare January 6, 2025 14:51
@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 6, 2025 15:07
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Jan 6, 2025

tested with kernel 6.6 again. still works

ping @Mic92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant