Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for GV302X* 2023 #1285

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

sjhaleprogrammer
Copy link

Description of changes
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

asus/flow/gv302xi/shared.nix Outdated Show resolved Hide resolved
# https://wiki.archlinux.org/title/Iwd#iwd_keeps_roaming
#
# But NixOS doesn't have the tweaks for IWD, yet.
networking.wireless.iwd.settings = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second time we copy this around. Can we move this to a module?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, i don't know where to move it to though.

@sjhaleprogrammer sjhaleprogrammer changed the title Adding support for GV302XI Adding support for GV302X* Dec 23, 2024
@sjhaleprogrammer sjhaleprogrammer changed the title Adding support for GV302X* Adding support for GV302X* 2023 Dec 23, 2024
@jlnr
Copy link

jlnr commented Dec 24, 2024

Sorry to stumble into this PR, but @sjhaleprogrammer are there any notable issues left with your changes? Do things like standby and external screens work, or screen auto-rotation? I couldn't find much online about Linux on ASUS' convertibles, much less this particular model. (I am soooo tempted to get the GV302XI — if I do so, I promise to make NixOS my first distro on it :D)

@sjhaleprogrammer
Copy link
Author

sjhaleprogrammer commented Dec 24, 2024

Sorry to stumble into this PR, but @sjhaleprogrammer are there any notable issues left with your changes? Do things like standby and external screens work, or screen auto-rotation? I couldn't find much online about Linux on ASUS' convertibles, much less this particular model. (I am soooo tempted to get the GV302XI — if I do so, I promise to make NixOS my first distro on it :D)

Ya sensor.iio.enable = true; could be added to shared.nix I have it in my configuration atm

everything works well. besides suspend in some cases

@sjhaleprogrammer
Copy link
Author

Finalized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants