-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for GV302X* 2023 #1285
base: master
Are you sure you want to change the base?
Conversation
asus/flow/gv302xi/shared.nix
Outdated
# https://wiki.archlinux.org/title/Iwd#iwd_keeps_roaming | ||
# | ||
# But NixOS doesn't have the tweaks for IWD, yet. | ||
networking.wireless.iwd.settings = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the second time we copy this around. Can we move this to a module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, i don't know where to move it to though.
Sorry to stumble into this PR, but @sjhaleprogrammer are there any notable issues left with your changes? Do things like standby and external screens work, or screen auto-rotation? I couldn't find much online about Linux on ASUS' convertibles, much less this particular model. (I am soooo tempted to get the GV302XI — if I do so, I promise to make NixOS my first distro on it :D) |
Ya sensor.iio.enable = true; could be added to shared.nix I have it in my configuration atm everything works well. besides suspend in some cases |
Finalized |
Description of changes
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input