lenovo/yoga/7/pro-x: add 14IAH7; create shared for 14ARH7 and 14IAH7 #1284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
nixos-hardware
already had Lenovo 14ARH7 (Lenovo Yoga Slim 7 Pro X) modelprofiles. This an AMD device with an NVIDIA dedicated GPU. There is a profile
for integrated graphics only and another for hybrid graphics.
There is an Intel version of the same device, the Lenovo 14IAH7 (Lenovo Yoga
Slim 7i Pro X). Seeing as they are primarily the same device, save the
difference in processor under the Lenovo Yoga Slim 7 Pro X "line", the listed
was done to share values between the AMD version and the Intel version that was
added in this commit. It follows the same pattern of having a profile for
integrated graphics only and another for hybrid graphics.
The implementation for the 14ARH7 modules was changed during this, but the goals
were entirely maintained. There was a considerable amount of redundant rewriting
of values that were in imported modules. An effort to remove unnecessary
declarations in favour of importing common modules was done. "Optional" values
were assigned with
lib.mkDefault
as well, such as forhardware.nvidia.nvidiaSettings
. According toCONTRIBUTING.md
, this isencouraged.
The 14ARH7
nixosModule
names were left as is to not cause unnecessarybreakages.
lenovo/yoga/7
lenovo/yoga/7/pro-x/shared
flake.nix
andREADME.md
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input