Add Odroid M1 #1269
Add Odroid M1 #1269
Conversation
| # Use kernel >6.6 The devicetree is missing from kernel versions older than this. | ||
| boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.6") (lib.mkDefault pkgs.linuxPackages_latest); | ||
| # Stop ZFS breaking the build | ||
| boot.supportedFilesystems = lib.mkForce ["btrfs" "cifs" "f2fs" "jfs" "ntfs" "reiserfs" "vfat" "xfs"]; |
There was a problem hiding this comment.
This can be potentially dangerous if other module try to add something. Why is it needed for linuxPackages_latest? Nothing should add zfs by default.
There was a problem hiding this comment.
I don't think it'd be necessary for linuxPackages_latest, I'll do some tests and remove boot.supportedFilesystems.
There was a problem hiding this comment.
Removing the boot.supportedFilesystems line breaks the boot flow and unfortunately I haven't figured out why yet. So I've put it back for the time being.
|
|
||
| # I'm not completely sure if some of these could be omitted, | ||
| # but want to make sure disk access works | ||
| boot.initrd.availableKernelModules = [ |
There was a problem hiding this comment.
Can you run nixos-generate-config and see what modules it emits?
There was a problem hiding this comment.
Will try and get back to you.
There was a problem hiding this comment.
I ran nixos-generate-config and the generated list of available kernel modules remains empty. Here's the code I use to build my SD Image: https://github.com/KhashayarDanesh/nixos-on-odroid-m1
|
@Mic92 Do you have any general tips/suggestions for this change except for addressing the items that came up and the things mentioned in the contribution guide? I'm a bit of a newbie and would appreciate all of the suggestion and direction I can get :) |
Rest looks fine. |
Description of changes
I've added the Odroid M1 to nixos-hardware.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input.