Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dell XPS 13 9340 and Meteor Lake #1134

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JohnMolotov
Copy link

Description of changes

Support for the Dell XPS 13 9340, with configuration that applies to all Meteor Lake (Core Ultra) CPUs cleanly separated.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

Whitespace consistency

Co-authored-by: Jörg Thalheim <[email protected]>
@Mic92 Mic92 marked this pull request as draft September 27, 2024 11:15

config = {
# i915 is buggy on meteor lake, xe should be the default
hardware.intelgpu.driver = mkDefault "xe";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a Dell Latitude 7450 with an Intel Core Ultra 7 165U.
In my tests so far the Xe driver, while providing the best experience right at boot (correct resolutions etc.), was very unstable.
Everytime I watched a video either with MPV or in the browser the device crashed after max. 10 minutes.
I'm currently running the i915 driver and so far it has been working fine.

Therefore I'm not sure it is fair to say that i915 is buggy on Meteor Lake. However I'm not the best when it comes to hardware.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I found the i915 driver to be unusably buggy on an XPS9340, while the xe driver works fine. I'll look more into it and see if there's some other factor.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently using the Dell Precision 5390 with an Intel Core Ultra 7 165H with this patch and also the Xe driver and haven't noticed any issues so far. But I'm using this system only for 2 days.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm interesting, that is a very similar CPU.
My setup is here, AFAIK I’m not doing something exotic but maybe miss something obvious.
https://git.2li.ch/Nebucatnetzer/nixos/src/branch/new-notebook/systems/capricorn/default.nix

I tried it again yesterday and Xe failed reproducible when watching a video with the same config except for the force_probe.
Which looked like this: https://git.2li.ch/Nebucatnetzer/nixos/commit/edeac6d6922c29e78126386c563e976e79cff23c

@Sh3Rm4n is suspend working for you? If so are you using an encrypted drive?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using an encrypted drive and haven't explicitly checked suspend so far, but I think it is currently not working correctly. I'll recheck again.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just see this, the boot is because I killed the system.

Jan 22 20:56:19 capricorn systemd[1]: Starting System Suspend...
Jan 22 20:56:19 capricorn systemd-sleep[14013]: Successfully froze unit 'user.slice'.
Jan 22 20:56:19 capricorn systemd-sleep[14013]: Performing sleep operation 'suspend'...
Jan 22 20:56:19 capricorn kernel: PM: suspend entry (s2idle)
Jan 22 20:56:19 capricorn kernel: Filesystems sync: 0.009 seconds
-- Boot 412e6ed5b57b47d3a8552a5e9d53befb --

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a Dell Latitude 7450 with an Intel Core Ultra 7 165U. In my tests so far the Xe driver, while providing the best experience right at boot (correct resolutions etc.), was very unstable. Every time I watched a video either with MPV or in the browser the device crashed after max. 10 minutes. I'm currently running the i915 driver and so far it has been working fine.

Therefore I'm not sure it is fair to say that i915 is buggy on Meteor Lake. However I'm not the best when it comes to hardware.

Just to be sure I tested this PR and the settings from nixos-hardware explicitly and I'm seeing the same behaviour.
In addition I have to force_probe the Xe driver otherwise the notebook doesn't detect my external monitor.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What just came to my mind.
Are you guys using X11 or Wayland or wouldn't that make a difference?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use plasma with wayland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved the suspend problem by removing the webcam option.
Sorry for the detour.

@Nebucatnetzer
Copy link

BTW. shouldn't both the machine and the CPU files be added to the flake.nix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants