[Backport 2.12-maintenance] faster flake lock parsing #10189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This PR reduces the creation of short-lived basic_json objects while parsing flake.lock files. For large flake.lock files (~1.5MB) I was observing ~60s being spent for trivial nix build operations while after this change it is now taking ~1.6s. (cherry picked from commit 7fd0de3) (cherry picked from commit f94fb63)
github-actions
bot
requested review from
edolstra and
thufschmitt
as code owners
roberth
changed the title
|
This targets an unsupported Nix release. The CI is broken there and I'd rather keep the sub-efficient behavior than merging something untested. So closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic backport to
2.12-maintenance, triggered by a label in #10183.