Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Soumya-Kushwaha
Copy link

Fixes #5

@vercel
Copy link

vercel bot commented Apr 8, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @NishanthMuruganantham on Vercel.

@NishanthMuruganantham first needs to authorize it.

@NishanthMuruganantham
Copy link
Owner

Hi @Soumya-Kushwaha ,
Thanks for the contribution. But, here's a glitch. The URL is https://ndtvapi.vercel.app/. Hence, the replacements should be done with respect to this URL.

README.md Outdated
@@ -2,7 +2,7 @@

<p>This API will scrap the news content present in the NDTV website will provide the data in a JSON format.</p>

URL : https://ndtvnews-api.herokuapp.com
URL : https://ndtvnews-api.vercel.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URL : https://ndtvnews-api.vercel.com
URL : https://ndtvapi.vercel.app/

README.md Outdated
@@ -35,7 +35,7 @@ Below are the endpoints available in this API.

<p>Please find the instructions for using the respective endpoints.</p>

<h3>For https://ndtvnews-api.herokuapp.com/general :-</h3>
<h3>For https://ndtvnews-api.vercel.com/general :-</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3>For https://ndtvnews-api.vercel.com/general :-</h3>
<h3>For https://ndtvapi.vercel.app/general :-</h3>

README.md Outdated
@@ -56,15 +56,15 @@ Below are the endpoints available in this API.

Key | Name |Example
---------|----------|---------
category | news category you wish to get | https://ndtvnews-api.herokuapp.com/general?category=values(latest,india,world)
field | field content | https://ndtvnews-api.herokuapp.com/general?field=values(headline,description,url)
category | news category you wish to get | https://ndtvnews-api.vercel.com/general?category=values(latest,india,world)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
category | news category you wish to get | https://ndtvnews-api.vercel.com/general?category=values(latest,india,world)
category | news category you wish to get | https://ndtvapi.vercel.app/general?category=values(latest,india,world)

@NishanthMuruganantham
Copy link
Owner

Kindly make the relevant changes based on the mentioned sugesstions.

Thanks again for coming forward. 😊

Copy link
Owner

@NishanthMuruganantham NishanthMuruganantham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes

@vercel
Copy link

vercel bot commented Apr 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ndtv-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2023 5:15pm

@Soumya-Kushwaha
Copy link
Author

@NishanthMuruganantham still not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the README.md file with the new vercel URL by replacing the herokuspp URL
2 participants