#208: ShyLU: Add Tpetra tests #209

cwschilly · 2023-09-21T19:55:36Z

Fixes #208

Creates the following tests:

shylu_factor_test_tpetra.cpp
shylu_belos_driver_tpetra.cpp

packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

github-actions · 2023-09-22T00:59:40Z

⚡ Code quality check ⚡

🔴 cppcheck found 29 issues! Click here to see details.

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 24 to 29 in 744a5f3

    
           #include "Teuchos_RCP.hpp" 
        
           #include "Teuchos_GlobalMPISession.hpp" 
        
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           // MueLu 
        
           #include <MueLu_TpetraOperator.hpp>

!Line: 24 - information: Include file: "Teuchos_RCP.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 25 to 30 in 744a5f3

    
           #include "Teuchos_GlobalMPISession.hpp" 
        
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           // MueLu 
        
           #include <MueLu_TpetraOperator.hpp> 
        
           #include <MueLu_CreateTpetraPreconditioner.hpp>

!Line: 25 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 26 to 31 in 744a5f3

    
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           // MueLu 
        
           #include <MueLu_TpetraOperator.hpp> 
        
           #include <MueLu_CreateTpetraPreconditioner.hpp>

!Line: 26 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 37 to 42 in 744a5f3

    
           #include "shylu.h" 
        
           #include "shylu_util.h" 
        
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp"

!Line: 37 - information: Include file: "shylu.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 38 to 43 in 744a5f3

    
           #include "shylu_util.h" 
        
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp"

!Line: 38 - information: Include file: "shylu_util.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 39 to 44 in 744a5f3

    
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp" 
        
           // Will likely have to move somewhere

!Line: 39 - information: Include file: "ShyLU_DDCore_config.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 40 to 45 in 744a5f3

    
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp" 
        
           // Will likely have to move somewhere 
        
           int InitMatValues( const tcrsmatrix_t& newA, tcrsmatrix_t* A );

!Line: 40 - information: Include file: "shylu_partition_interface.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 41 to 46 in 744a5f3

    
           #include "shylu_directsolver_interface.hpp" 
        
           // Will likely have to move somewhere 
        
           int InitMatValues( const tcrsmatrix_t& newA, tcrsmatrix_t* A ); 
        
           int InitMVValues( const MV& newb, MV* b );

!Line: 41 - information: Include file: "shylu_directsolver_interface.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 459 to 464 in 744a5f3

    
               delete prec; 
        
           } 
        
           delete newX; 
        
           delete newB; 
        
           delete A; 
        
           delete partitioner;

!Line: 459 - error: Found an exit path from function with non-void return type that has missing return statement [missingReturn]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 500 to 505 in 744a5f3

    
           const tvector_t *tempnewvec; 
        
           tvector_t *tempvec = 0; 
        
           for (int i=0; i<numVecs; ++i) { 
        
             tempnewvec = newb(i); 
        
             tempvec = (*b)(i);

!Line: 500 - style: The scope of the variable 'tempnewvec' can be reduced. [variableScope]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 501 to 506 in 744a5f3

    
           tvector_t *tempvec = 0; 
        
           for (int i=0; i<numVecs; ++i) { 
        
             tempnewvec = newb(i); 
        
             tempvec = (*b)(i); 
        
             for (int j=0; j<length; ++j)

!Line: 501 - style: The scope of the variable 'tempvec' can be reduced. [variableScope]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 296 to 301 in 744a5f3

    
               success = false; 
        
               return -1; 
        
           } 
        
           // Create an iterative solver manager. 
        
           RCP< Belos::SolverManager<double,MV,OP> > solver

!Line: 296 - style: Variable 'success' is assigned a value that is never used. [unreadVariable]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_belos_driver_tpetra.cpp

Lines 501 to 506 in 744a5f3

    
           tvector_t *tempvec = 0; 
        
           for (int i=0; i<numVecs; ++i) { 
        
             tempnewvec = newb(i); 
        
             tempvec = (*b)(i); 
        
             for (int j=0; j<length; ++j)

!Line: 501 - style: Variable 'tempvec' is assigned a value that is never used. [unreadVariable]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 16 to 21 in 744a5f3

    
           #include "Isorropia_config.h" // Just for HAVE_MPI 
        
           #include <Ifpack2_Partitioner.hpp> 
        
           // Tpetra includes 
        
           #include <Tpetra_Core.hpp>

!Line: 16 - information: Include file: "Isorropia_config.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 28 to 33 in 744a5f3

    
           #include "Teuchos_GlobalMPISession.hpp" 
        
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           // Amesos2 includes 
        
           #include <Amesos2.hpp>

!Line: 28 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 29 to 34 in 744a5f3

    
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           // Amesos2 includes 
        
           #include <Amesos2.hpp> 
        
           // MueLu includes

!Line: 29 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 37 to 42 in 744a5f3

    
           #include "shylu.h" 
        
           #include "shylu_util.h" 
        
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp"

!Line: 37 - information: Include file: "shylu.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 38 to 43 in 744a5f3

    
           #include "shylu_util.h" 
        
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp"

!Line: 38 - information: Include file: "shylu_util.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 39 to 44 in 744a5f3

    
           #include "ShyLU_DDCore_config.h" 
        
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp" 
        
           using namespace std;

!Line: 39 - information: Include file: "ShyLU_DDCore_config.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 40 to 45 in 744a5f3

    
           #include "shylu_partition_interface.hpp" 
        
           #include "shylu_directsolver_interface.hpp" 
        
           using namespace std;

!Line: 40 - information: Include file: "shylu_partition_interface.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_driver_tpetra.cpp

Lines 41 to 46 in 744a5f3

    
           #include "shylu_directsolver_interface.hpp" 
        
           using namespace std; 
        
           template <typename ScalarType>

!Line: 41 - information: Include file: "shylu_directsolver_interface.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 17 to 22 in 744a5f3

    
           #include "Isorropia_config.h" // Just for HAVE_MPI 
        
           // #include "Epetra_LinearProblem.h" 
        
           // Tpetra includes 
        
           #include <Tpetra_Core.hpp>

!Line: 17 - information: Include file: "Isorropia_config.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 29 to 34 in 744a5f3

    
           #include "Teuchos_GlobalMPISession.hpp" 
        
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           #include "Teuchos_RCP.hpp" 
        
           #include "shylu.h" 
        
           #include "shylu_util.h"

!Line: 29 - information: Include file: "Teuchos_GlobalMPISession.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 30 to 35 in 744a5f3

    
           #include "Teuchos_XMLParameterListHelpers.hpp" 
        
           #include "Teuchos_RCP.hpp" 
        
           #include "shylu.h" 
        
           #include "shylu_util.h"

!Line: 30 - information: Include file: "Teuchos_XMLParameterListHelpers.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 31 to 36 in 744a5f3

    
           #include "Teuchos_RCP.hpp" 
        
           #include "shylu.h" 
        
           #include "shylu_util.h" 
        
           using namespace std;

!Line: 31 - information: Include file: "Teuchos_RCP.hpp" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 33 to 38 in 744a5f3

    
           #include "shylu.h" 
        
           #include "shylu_util.h" 
        
           using namespace std;

!Line: 33 - information: Include file: "shylu.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 34 to 39 in 744a5f3

    
           #include "shylu_util.h" 
        
           using namespace std; 
        
           template <typename ScalarType>

!Line: 34 - information: Include file: "shylu_util.h" not found. [missingInclude]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 63 to 68 in 744a5f3

    
           string pass = "End Result: TEST PASSED"; 
        
           string fail = "End Result: TEST FAILED"; 
        
           int myPID = Comm->getRank(); 
        
           if(myPID == 0)

!Line: 63 - style: The scope of the variable 'pass' can be reduced. [variableScope]

Trilinos/packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp

Lines 64 to 69 in 744a5f3

    
           string fail = "End Result: TEST FAILED"; 
        
           int myPID = Comm->getRank(); 
        
           if(myPID == 0) 
        
             {

!Line: 64 - style: The scope of the variable 'fail' can be reduced. [variableScope]

cwschilly · 2023-09-25T17:29:19Z

I am having difficulty configuring Trilinos to actually build the shylu_dd/core directory so that I can build/test these tests. I'll leave this PR as is for now

JacobDomagala · 2023-09-28T15:52:13Z

Add:

-D Trilinos_ENABLE_Zoltan2=OFF \      
-D Trilinos_ENABLE_Zoltan2Core=ON \

Should work

#208: create shylu_factor_test_tpetra.cpp

724ff30

cwschilly linked an issue Sep 21, 2023 that may be closed by this pull request

ShyLU: Add Tpetra tests #208

Open

stmcgovern reviewed Sep 21, 2023

View reviewed changes

packages/shylu/shylu_dd/core/test/shylu_factor_test_tpetra.cpp Outdated Show resolved Hide resolved

cwschilly added 2 commits September 21, 2023 17:08

#208: create shylu_belos_driver_tpetra.cpp test

434641c

#208: continue work on shylu_belos_driver

a31be8d

cwschilly marked this pull request as draft September 22, 2023 12:50

cwschilly mentioned this pull request Sep 22, 2023

List of PRs to Trilinos/develop and fork development #77

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#208: ShyLU: Add Tpetra tests #209

#208: ShyLU: Add Tpetra tests #209

cwschilly commented Sep 21, 2023 •

edited by tlamonthezie

Loading

github-actions bot commented Sep 22, 2023 •

edited

Loading

cwschilly commented Sep 25, 2023

JacobDomagala commented Sep 28, 2023 •

edited

Loading

#208: ShyLU: Add Tpetra tests #209

Are you sure you want to change the base?

#208: ShyLU: Add Tpetra tests #209

Conversation

cwschilly commented Sep 21, 2023 • edited by tlamonthezie Loading

github-actions bot commented Sep 22, 2023 • edited Loading

⚡ Code quality check ⚡

cwschilly commented Sep 25, 2023

JacobDomagala commented Sep 28, 2023 • edited Loading

cwschilly commented Sep 21, 2023 •

edited by tlamonthezie

Loading

github-actions bot commented Sep 22, 2023 •

edited

Loading

JacobDomagala commented Sep 28, 2023 •

edited

Loading