Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[노철]- 이메일 인증 에러 핸들링 #403

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[노철]- 이메일 인증 에러 핸들링 #403

merged 3 commits into from
Jan 8, 2024

Conversation

qkdl60
Copy link
Contributor

@qkdl60 qkdl60 commented Jan 5, 2024

📌 이슈 번호

close #402

🚀 구현 내용

  • 이메일 인증 관련 에러를 useEffect로 하고 있었는데 적절하지 않아서 react-query의 throwOnError로 변경
  • html lang ko 변경

@qkdl60 qkdl60 added the 🚨긴급 긴급한 확인 필요 label Jan 5, 2024
@qkdl60 qkdl60 added this to the V1.1 milestone Jan 5, 2024
@qkdl60 qkdl60 requested review from MinwooP and suehdn January 5, 2024 15:42
@qkdl60 qkdl60 self-assigned this Jan 5, 2024
MinwooP
MinwooP approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@MinwooP MinwooP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 효율적이고 좋은 방법인 것 같습니다 !! 고생하셨습니다 👍🏻😗

@suehdn
Copy link
Contributor

suehdn commented Jan 7, 2024

더 개선되어서 좋은 것 같습니다. 고생하셨습니다!! 👍

@qkdl60 qkdl60 merged commit a700110 into dev Jan 8, 2024
@qkdl60 qkdl60 deleted the feat/#402/verify-error-handling branch January 8, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suehdn suehdn suehdn approved these changes

@MinwooP MinwooP MinwooP approved these changes

Assignees

@qkdl60 qkdl60

Labels
🚨긴급 긴급한 확인 필요
Projects
None yet
Milestone
V1.1
Development

Successfully merging this pull request may close these issues.

[노철] - 이메일 인증 에러 핸들링
3 participants
@qkdl60 @suehdn @MinwooP