Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[노철] - 쿠키 저장 및 라우팅 방식 변경 #325

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[노철] - 쿠키 저장 및 라우팅 방식 변경 #325

merged 2 commits into from
Dec 27, 2023

Conversation

qkdl60
Copy link
Contributor

@qkdl60 qkdl60 commented Dec 27, 2023

📌 이슈 번호

close #324

🚀 구현 내용

  • 쿠키저장 후 라우팅을 windwow.location.replace() 로 변경, 새로고침으로 바로 쿠키적용

@qkdl60 qkdl60 added the 🚨긴급 긴급한 확인 필요 label Dec 27, 2023
@qkdl60 qkdl60 added this to the V1.1 milestone Dec 27, 2023
@qkdl60 qkdl60 self-assigned this Dec 27, 2023
MinwooP
MinwooP approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@MinwooP MinwooP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ! 근데 router로 주소변경하는 것과 window.location으로 주소변경하는 거에 따라서 request에 쿠키가 들어가고 안들어가고 다르다는 게 신기하네요,,,

@qkdl60 qkdl60 merged commit c207ec9 into dev Dec 27, 2023
@qkdl60 qkdl60 deleted the feat/#324/loading-error branch December 27, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinwooP MinwooP MinwooP approved these changes

@suehdn suehdn Awaiting requested review from suehdn

Assignees

@qkdl60 qkdl60

Labels
🚨긴급 긴급한 확인 필요
Projects
None yet
Milestone
V1.1
Development

Successfully merging this pull request may close these issues.

[노철] - 쿠키 저장 및 라우팅
2 participants
@qkdl60 @MinwooP