Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[혜수] - 공통 아좌좌 버튼 상태 컴포넌트 안으로 이동 #28

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[혜수] - 공통 아좌좌 버튼 상태 컴포넌트 안으로 이동 #28

merged 2 commits into from
Nov 7, 2023

Conversation

suehdn
Copy link
Contributor

@suehdn suehdn commented Nov 7, 2023 •
edited
Loading

📌 이슈 번호

close #27

🚀 구현 내용

  • 디바운스 훅 추가
  • 아좌좌 버튼의 상태 컴포넌트 안으로 이동

📘 참고 사항

캡슐화 해놨습니다.

interface AjajaButtonProps {
  isFilled: boolean;
  ajajaCount: number;
}

<AjajaButton isFilled={false} ajajaCount={0} />

훅으로 빼놔서 어제 멘토님이 말해주신 방법이 적용이 잘 안되어서 일단 컴포넌트 안에 디바운스를 넣어놨습니다.

@suehdn suehdn added the 🚨긴급 긴급한 확인 필요 label Nov 7, 2023
@suehdn suehdn requested review from MinwooP and qkdl60 November 7, 2023 03:40
@suehdn suehdn self-assigned this Nov 7, 2023
MinwooP
MinwooP approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MinwooP MinwooP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디바운스 훅까지,, 👍🏻 고생 많으셨슴다 ! !

@suehdn suehdn merged commit 20ba8dc into dev Nov 7, 2023
@suehdn suehdn deleted the feat/#27/button branch November 7, 2023 05:42
qkdl60
qkdl60 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@qkdl60 qkdl60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/hooks/useDebounce.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디바운스도 잘 쓰겠습니다👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkdl60 qkdl60 qkdl60 approved these changes

@MinwooP MinwooP MinwooP approved these changes

Assignees

@suehdn suehdn

Labels
🚨긴급 긴급한 확인 필요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[혜수] - 공통 아좌좌 버튼 상태 컴포넌트 안으로 이동
3 participants
@suehdn @MinwooP @qkdl60