Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[민우] - 에러 핸들링: 페이지 에러 바운더리 #176

Merged
merged 6 commits into from
Nov 28, 2023
Merged

[민우] - 에러 핸들링: 페이지 에러 바운더리 #176

merged 6 commits into from
Nov 28, 2023

Conversation

MinwooP
Copy link
Contributor

@MinwooP MinwooP commented Nov 28, 2023

📌 이슈 번호

close #172

🚀 구현 내용

  • 각 페이지에서 보여줄 BasicError 컴포넌트 구현
  • mutation 후 invalidQueries 연속으로 호출 시, PromiseAll 사용

@MinwooP MinwooP added the 🚨긴급 긴급한 확인 필요 label Nov 28, 2023
@MinwooP MinwooP self-assigned this Nov 28, 2023
suehdn
suehdn approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@suehdn suehdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 민우님! 에러 처리 파일 잘 쓰겠습니다

@MinwooP MinwooP merged commit 6203f74 into dev Nov 28, 2023
qkdl60
qkdl60 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@qkdl60 qkdl60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@MinwooP MinwooP deleted the feat/#172/error-boundary branch December 22, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suehdn suehdn suehdn approved these changes

@qkdl60 qkdl60 qkdl60 approved these changes

Assignees

@MinwooP MinwooP

Labels
🚨긴급 긴급한 확인 필요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[민우] - 에러 핸들링: 페이지 에러 바운더리
3 participants
@MinwooP @qkdl60 @suehdn