Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[혜수] - 로그인 하지 않은 유저일 때 카드 컴포넌트 클릭 시 로그인 유도 모달 추가 #174

Merged
merged 2 commits into from
Nov 28, 2023
Merged

[혜수] - 로그인 하지 않은 유저일 때 카드 컴포넌트 클릭 시 로그인 유도 모달 추가 #174

merged 2 commits into from
Nov 28, 2023

Conversation

suehdn
Copy link
Contributor

@suehdn suehdn commented Nov 27, 2023 •
edited
Loading

📌 이슈 번호

close #173

🚀 구현 내용

  • 로그인 하지 않은 유저일 때 카드 컴포넌트 클릭 시 로그인 유도 모달 추가
  • 모달 블러처리 화면 전체로 수정

📘 참고 사항

image

@suehdn suehdn added 🚨긴급 긴급한 확인 필요 🐛버그 버그 labels Nov 27, 2023
@suehdn suehdn self-assigned this Nov 27, 2023
MinwooP
MinwooP approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@MinwooP MinwooP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르시네여 ~~ 굿굿 !

qkdl60
qkdl60 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@qkdl60 qkdl60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

src/app/(header)/explore/_components/ExplorePlans.tsx
isLogin: boolean;
};

export default function ExplorePlans({ isLogin }: ExplorePlansProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정👍👍`

@suehdn suehdn merged commit ad618e2 into dev Nov 28, 2023
@suehdn suehdn deleted the feat/#173/login-modal branch November 28, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkdl60 qkdl60 qkdl60 approved these changes

@MinwooP MinwooP MinwooP approved these changes

Assignees

@suehdn suehdn

Labels
🐛버그 버그 🚨긴급 긴급한 확인 필요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[혜수] - 로그인 하지 않은 유저일 때 카드 컴포넌트 클릭 시 로그인 유도 모달 추가
3 participants
@suehdn @MinwooP @qkdl60