[노철] - api 에러 핸들링 #166
Merged
[노철] - api 에러 핸들링 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinwooP
approved these changes
Nov 27, 2023
| await submitCertification(code).catch((error: AxiosError) => { | ||
| if (error && error.response) { | ||
| const status = error.response.status; | ||
| if (status <= 400 || status >= 500) throw error; |
There was a problem hiding this comment.
이 부분이 네트워크 연결 실패나 기타 이유로 에러일 경우 페이지 단위 에러 바운더리로 넘기기 위해 다시 throw 하는 부분일까요 ??
There was a problem hiding this comment.
네 401부터 409까지는 인증 결과 에러입니다.
…into feat/#153/api-error-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 번호
close #153
🚀 구현 내용