Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(.security): apply interceptor from aspect, handlerResolver form utility class #201

Merged
merged 9 commits into from
Mar 26, 2024

Conversation

Hejow
Copy link
Member

@Hejow Hejow commented Mar 21, 2024

πŸ” μ–΄λ–€ PRμΈκ°€μš”?

  • μΈκ°€μ²˜λ¦¬ κ΄€λ ¨ν•œ μž‘μ—…μ„ λ¦¬νŒ©ν† λ§ ν–ˆμŠ΅λ‹ˆλ‹€.
  • Api time check μ½”λ“œλ₯Ό 일뢀 λ¦¬νŒ©ν† λ§ ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ˜‹ To Reviewer

  • AOP둜 적용되던 인가 처리λ₯Ό 보닀 μ•žλ‹¨μ—μ„œ μ²˜λ¦¬ν•˜λ„λ‘ 인터셉터λ₯Ό μ μš©μ‹œμΌ°μŠ΅λ‹ˆλ‹€.
  • AOPκ°€ λ™μž‘ν•˜λŠ” μ‹œμ  λ•Œλ¬Έμ— μ‚¬μš©ν•˜λ˜ μœ ν‹Έλ¦¬ν‹° 클래슀(SecurityUtil)을 μ‚­μ œ μ‹œν‚€κ³  μ–΄λ…Έν…Œμ΄μ…˜μ„ ν™œμš©ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. 인가가 μ²˜λ¦¬λ˜μ§€ μ•Šκ³  contextμ—μ„œ 값을 κΊΌλ‚Ό μ‹œ μ˜ˆμ™Έκ°€ λ°œμƒν•©λ‹ˆλ‹€.
  • 인가λ₯Ό μš”μ²­ μ–΄λ…Έν…Œμ΄μ…˜μ˜ 가독성을 μœ„ν•΄ 넀이밍을 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. (@Authorization -> @Authorize)
  • (24.03.26 μΆ”κ°€) μΈν„°μ…‰ν„°λ‘œ μΈν•œ ν…ŒμŠ€νŠΈ μ‹€νŒ¨λ‘œ 기쑴에 Security 토큰 μ œμ–΄λ₯Ό μœ„ν•΄μ„œ μ‚¬μš©ν•˜λ˜ SecurityFactoryλŠ” μ‚­μ œν–ˆμŠ΅λ‹ˆλ‹€.
  • 일뢀 μ½”λ“œ κ°œμ„ λ„ 반영 ν–ˆμŠ΅λ‹ˆλ‹€.

@Hejow Hejow self-assigned this Mar 21, 2024
Copy link
Member

@JuwoongKim JuwoongKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν¬μ‘°λ‹˜ 인터셉터, μ•„νλ¨ΌνŠΈ 리쑸버 μ»€μŠ€ν…€ ν™œμš©μ‚¬λ‘€ μž˜λ΄€μŠ΅λ‹ˆλ‹€. μž¬λ°Œλ„€μœ  γ…Žγ…Ž

Copy link
Contributor

@2jie0516 2jie0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!!
인터셉터와 리쑸버 ν™œμš©ν•΄μ„œ 쀑볡 μ½”λ“œλ“€μ΄ μ‚¬λΌμ§„κ²Œ 쒋은거 κ°™λ„€μš” γ…Žγ…Ž
μ‹œκ°„μ΄ 되면 더 곡뢀해보고 싢은 μ½”λ“œμ˜€μŠ΅λ‹ˆλ‹Ή

Copy link

Test Coverage Report

Overall Project 71.24% -1.28% 🍏
Files changed 57.56% ❌

File Coverage
UpdateRemindInfoService.java 100% 🍏
GetTargetInfoService.java 100% 🍏
GetMyPageController.java 100% 🍏
SendVerificationController.java 100% 🍏
VerifyCertificationController.java 100% 🍏
LogoutController.java 100% 🍏
ChangeRemindTypeController.java 100% 🍏
WithdrawController.java 100% 🍏
RefreshNicknameController.java 100% 🍏
ApplyChangeAdapter.java 100% 🍏
CreateFootprintController.java 100% 🍏
CreatePlanController.java 100% 🍏
SwitchPlanStatusController.java 100% 🍏
DeletePlanController.java 100% 🍏
ValidateBanWordController.java 100% 🍏
SwitchAjajaController.java 100% 🍏
UpdatePlanController.java 100% 🍏
AuthorizationInterceptor.java 100% 🍏
LogoutService.java 100% 🍏
UpdateRemindInfoController.java 100% 🍏
GetPlanInfoController.java 100% 🍏
SendTrialRemindController.java 100% 🍏
GetRemindInfoController.java 100% 🍏
KakaoAuthorizeAdapter.java 100% 🍏
ValidateContentService.java 100% 🍏
FeedbackController.java 100% 🍏
GetPlanController.java 92% 🍏
AuthenticatedUserArgumentResolver.java 87.23% -12.77% 🍏
Remind.java 62.71% -8.47% ❌
SendEmailRemindStrategy.java 10.74% 🍏
SendAlimtalkRemindStrategy.java 10.08% 🍏
SendRemindStrategy.java 7.69% -28.85% ❌
SendTrialRemindService.java 0% ❌
RedisCounter.java 0% ❌
Sendable.java 0% -33.33% ❌

Copy link

Test Coverage Report

Overall Project 71.43% -0.85% 🍏
Files changed 73.27% 🍏

File Coverage
UpdateRemindInfoService.java 100% 🍏
GetTargetInfoService.java 100% 🍏
GetMyPageController.java 100% 🍏
SendVerificationController.java 100% 🍏
VerifyCertificationController.java 100% 🍏
LogoutController.java 100% 🍏
ChangeRemindTypeController.java 100% 🍏
WithdrawController.java 100% 🍏
RefreshNicknameController.java 100% 🍏
RedisCounter.java 100% 🍏
ApplyChangeAdapter.java 100% 🍏
CreateFootprintController.java 100% 🍏
CreatePlanController.java 100% 🍏
SwitchPlanStatusController.java 100% 🍏
DeletePlanController.java 100% 🍏
ValidateBanWordController.java 100% 🍏
SwitchAjajaController.java 100% 🍏
UpdatePlanController.java 100% 🍏
AuthorizationInterceptor.java 100% 🍏
LogoutService.java 100% 🍏
UpdateRemindInfoController.java 100% 🍏
GetPlanInfoController.java 100% 🍏
SendTrialRemindController.java 100% 🍏
GetRemindInfoController.java 100% 🍏
KakaoAuthorizeAdapter.java 100% 🍏
ValidateContentService.java 100% 🍏
FeedbackController.java 100% 🍏
GetPlanController.java 92% 🍏
AuthenticatedUserArgumentResolver.java 87.23% -12.77% 🍏
Remind.java 62.71% -8.47% ❌
SendEmailRemindStrategy.java 10.74% 🍏
SendAlimtalkRemindStrategy.java 10.08% 🍏
SendRemindStrategy.java 7.69% -28.85% ❌
SendTrialRemindService.java 0% ❌
Sendable.java 0% -33.33% ❌

@Hejow Hejow merged commit 1250917 into dev Mar 26, 2024
2 checks passed
@Hejow Hejow deleted the refactor/authorization branch March 26, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants