-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add(.footprint): 발자취 확정된 컬럼 반영 #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Coverage Report
|
2jie0516
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 작성하시느라 수고하셨습니다!
소소한 의견 하나 남겼습니다
src/main/java/me/ajaja/module/footprint/adapter/out/persistence/model/FootprintEntity.java
Show resolved
Hide resolved
Hejow
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
미리 만들어놔서 고생하는 코드군요 아하하하~
리뷰 한번 확인해보시지요!
src/main/java/me/ajaja/module/footprint/adapter/out/persistence/model/FootprintEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/domain/AjajaFootprint.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V13__add_emoticon_on_footprint.sql
Outdated
Show resolved
Hide resolved
Test Coverage Report
|
Hejow
approved these changes
Mar 21, 2024
Test Coverage Report
|
Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 어떤 PR인가요?
😋 To Reviewer
필요한 컬럼을 추가하고 도메인, 엔티티, DTO, 매퍼, 테스트 코드에 반영했습니다.
조회, 수정기능 구현 전 발자취 도메인을 점검하기 위해 pr을 생성했습니다.
놓친점 또는 우려되는 점 위주로 피드백 주시면 감사하겠습니다.
기존 유형에 크게 벗어 나지 않도록 하기위헤 plan 도메인을 참조했습니다.
하지만 BaseTime, AjajaEntitiy의 필요성을 느끼지 못해 억지로 추가하지 않았습니다.
기능을 구현하며 필요하다면 추가해보도록 하겠습니다.
미리 조언해주셔도 괜찮을 것 같습니다.