Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add(.footprint): 발자취 확정된 컬럼 반영 #200

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Add(.footprint): 발자취 확정된 컬럼 반영 #200

merged 5 commits into from
Mar 22, 2024

Conversation

JuwoongKim
Copy link
Member

🔍 어떤 PR인가요?

  • 확정된 발자취 항목을 도메인과 엔티티에 반영했습니다.
  • 아좌좌 템플릿, 이모티콘 숫자를 반영했습니다.

😋 To Reviewer

  • 필요한 컬럼을 추가하고 도메인, 엔티티, DTO, 매퍼, 테스트 코드에 반영했습니다.

  • 조회, 수정기능 구현 전 발자취 도메인을 점검하기 위해 pr을 생성했습니다.
    놓친점 또는 우려되는 점 위주로 피드백 주시면 감사하겠습니다.

  • 기존 유형에 크게 벗어 나지 않도록 하기위헤 plan 도메인을 참조했습니다.
    하지만 BaseTime, AjajaEntitiy의 필요성을 느끼지 못해 억지로 추가하지 않았습니다.
    기능을 구현하며 필요하다면 추가해보도록 하겠습니다.
    미리 조언해주셔도 괜찮을 것 같습니다.

Copy link

Test Coverage Report

Overall Project 70.9% -1.05% 🍏
Files changed 60.11% 🍏

File Coverage
FreeFootprint.java 100% 🍏
Footprint.java 92.86% -2.38% 🍏
FootprintMapper.java 55.56% -26.39%
AjajaFootprint.java 42.59% -57.41%
FootprintRequest.java 0% 🍏

Copy link
Contributor

@2jie0516 2jie0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 작성하시느라 수고하셨습니다!
소소한 의견 하나 남겼습니다

Copy link
Member

@Hejow Hejow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미리 만들어놔서 고생하는 코드군요 아하하하~
리뷰 한번 확인해보시지요!

Copy link

Test Coverage Report

Overall Project 70.96% -0.97% 🍏
Files changed 62.92% 🍏

File Coverage
FreeFootprint.java 100% 🍏
Footprint.java 95.24% 🍏
FootprintMapper.java 55.56% -26.39%
AjajaFootprint.java 48.15% -51.85%
FootprintRequest.java 0% 🍏

Copy link

Test Coverage Report

Overall Project 70.35% -1.97% 🍏
Files changed 42.74%

File Coverage
FreeFootprint.java 100% 🍏
Content.java 100% 🍏
Footprint.java 73.53% -22.55%
FootprintMapper.java 50% -33.93%
FootprintRequest.java 0% 🍏
AjajaFootprint.java 0%

Copy link

Test Coverage Report

Overall Project 71.03% -1.14% 🍏
Files changed 61.88% 🍏

File Coverage
FreeFootprint.java 100% 🍏
FreeContent.java 100% 🍏
Footprint.java 92.22% -3.33% 🍏
AjajaContent.java 85% -15% 🍏
FootprintMapper.java 53.85% -28.85%
FootprintRequest.java 0% 🍏
AjajaFootprint.java 0%

@JuwoongKim JuwoongKim merged commit 2e25261 into dev Mar 22, 2024
2 checks passed
@JuwoongKim JuwoongKim deleted the getFoot branch March 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants