Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add(.footprint) : 발자취 생성 기능 및 API 추가 #185

Merged
merged 13 commits into from
Feb 29, 2024
Merged

Conversation

JuwoongKim
Copy link
Member

@JuwoongKim JuwoongKim commented Feb 27, 2024

🔍 어떤 PR인가요?

  • 발자취 생성 기능과 API를 구현했습니다.
  • pr 단위를 작게 하기 위해 태그 저장부분은 반영하지 않았습니다.
  • 태그는 담당자와 논의한 뒤 새로 PR을 만들어 개선하고 발자취에 반영하려고 합니다.

😋 To Reviewer

  • 기존 Requset 와 역할 구분이 어려웠던 FootprintParam 을 연관관계를 가지지 않는 발자취 데이터로 변경했습니다.
  • FootprintParam 탬플릿에 따른 요청, 응답값 데이터 변경 관리를 할 수 있는 엔드 포인트입니다.
  • 변경사항을 쉽게 관리하기 위해 표현 계층에서 사용하는 객체와, param의 관계는 다음과 같습니다.
Request {
   static Create{
       Param.Create param;
   }
}
  • 표현 계층에서 사용하는 request 가 서비스 로직까지 오는 것을 최대한 방지하고자 했습니다.
  • 발자취 생성 API url 에 대한 피드백 부탁드립니다.
    최대한 자원 식별을 할 수 있는 계층 구조를 생각해봤습니다.
    /targets/{target-id}/footprints
  • url 구성에 따라 controller 테스트에서도 "{}{}{}_END_POINT" 사용을 보류했습니다.
  • url 피드백 이후 반영하도록 하겠습니다

✅ 작성한 테스트

  • createFootPrint_Success_With_NoExceptions
  • createFootprint_Fail_By_NotFountTarget
  • createFootprint_Success_With_NoExceptions
  • createFootprint_Fail_By_InvalidContents

@JuwoongKim JuwoongKim added the enhancement New feature or request label Feb 27, 2024
@JuwoongKim JuwoongKim self-assigned this Feb 27, 2024
Copy link
Contributor

@2jie0516 2jie0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 작성하시느라 수고하셨습니다!

Copy link
Member

@Hejow Hejow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번에도 너무 많은 고민하신게 눈에 보였습니다!
개인적으로 DTO가 내부로 침입하는 정도는 상관없다고 생각합니다! DTO 보다는 더 중요한 것을 고민해야 한다고 생각하기 때문입니다 ㅎㅎ

Copy link

Test Coverage Report

Overall Project 80.44% -0.25% 🍏
Files changed 84.69% 🍏

File Coverage
Target.java 100% 🍏
Writer.java 100% 🍏
CreateFootprintService.java 100% 🍏
CreateFootprintController.java 100% 🍏
FootprintRequest.java 90.91% -9.09% 🍏
FootprintFactory.java 90.77% 🍏
FootprintTag.java 0%

Copy link
Member

@Hejow Hejow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가적으로 리뷰 남겨드렸습니다 확인해보세용 ㅎㅎ

Copy link

Test Coverage Report

Overall Project 80.49% -0.05% 🍏
Files changed 94.44% 🍏

File Coverage
Target.java 100% 🍏
Writer.java 100% 🍏
CreateFootprintService.java 100% 🍏
CreateFootprintController.java 100% 🍏
FootprintFactory.java 90.77% 🍏
FootprintRequest.java 0%

Copy link

Test Coverage Report

Overall Project 80.46% -0.05% 🍏
Files changed 94.74% 🍏

File Coverage
Title.java 100% 🍏
Target.java 100% 🍏
Writer.java 100% 🍏
CreateFootprintService.java 100% 🍏
CreateFootprintController.java 100% 🍏
FootprintFactory.java 88.68% 🍏
FootprintRequest.java 0%

Copy link

Test Coverage Report

Overall Project 79.85% -0.19% 🍏
Files changed 80.7% 🍏

File Coverage
Title.java 100% 🍏
Target.java 100% 🍏
Writer.java 100% 🍏
CreateFootprintService.java 100% 🍏
CreateFootprintController.java 100% 🍏
FootprintFactory.java 52.83% -15.09%
FootprintRequest.java 0%

Copy link

Test Coverage Report

Overall Project 80.46% -0.15% 🍏
Files changed 89.89% 🍏

File Coverage
Title.java 100% 🍏
Target.java 100% 🍏
Writer.java 100% 🍏
CreateFootprintService.java 100% 🍏
CreateFootprintController.java 100% 🍏
Footprint.java 92% -8% 🍏
FootprintRequest.java 0%

@Hejow Hejow merged commit aa2d139 into dev Feb 29, 2024
2 checks passed
@Hejow Hejow deleted the create-footprint branch February 29, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants