-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add(.footprint) : 발자취 생성 기능 및 API 추가 #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 작성하시느라 수고하셨습니다!
src/main/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintController.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/application/port/CreateFootprintService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번에도 너무 많은 고민하신게 눈에 보였습니다!
개인적으로 DTO가 내부로 침입하는 정도는 상관없다고 생각합니다! DTO 보다는 더 중요한 것을 고민해야 한다고 생각하기 때문입니다 ㅎㅎ
src/main/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintController.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/application/port/CreateFootprintService.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/dto/FootprintRequest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/application/port/CreateFootprintServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/application/port/CreateFootprintServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Outdated
Show resolved
Hide resolved
Test Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가적으로 리뷰 남겨드렸습니다 확인해보세용 ㅎㅎ
src/main/java/me/ajaja/module/footprint/application/port/CreateFootprintService.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/domain/FootprintFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/me/ajaja/module/footprint/dto/FootprintRequest.java
Outdated
Show resolved
Hide resolved
src/test/java/me/ajaja/module/footprint/application/port/CreateFootprintServiceTest.java
Outdated
Show resolved
Hide resolved
Test Coverage Report
|
Test Coverage Report
|
Test Coverage Report
|
src/test/java/me/ajaja/module/footprint/adapter/in/web/CreateFootprintControllerTest.java
Show resolved
Hide resolved
Test Coverage Report
|
🔍 어떤 PR인가요?
😋 To Reviewer
Requset
와 역할 구분이 어려웠던FootprintParam
을 연관관계를 가지지 않는 발자취 데이터로 변경했습니다.FootprintParam
탬플릿에 따른 요청, 응답값 데이터 변경 관리를 할 수 있는 엔드 포인트입니다.최대한 자원 식별을 할 수 있는 계층 구조를 생각해봤습니다.
/targets/{target-id}/footprints
✅ 작성한 테스트