-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle proxy error #184
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 481f4a2 - Browse repository at this point
Copy the full SHA 481f4a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7f3b3 - Browse repository at this point
Copy the full SHA 5c7f3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dc84bb - Browse repository at this point
Copy the full SHA 7dc84bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c0eed - Browse repository at this point
Copy the full SHA d7c0eedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02115a2 - Browse repository at this point
Copy the full SHA 02115a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed01a11 - Browse repository at this point
Copy the full SHA ed01a11View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 865a2b7 - Browse repository at this point
Copy the full SHA 865a2b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb3ff5 - Browse repository at this point
Copy the full SHA fbb3ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f97107 - Browse repository at this point
Copy the full SHA 3f97107View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32a828f - Browse repository at this point
Copy the full SHA 32a828fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66769da - Browse repository at this point
Copy the full SHA 66769daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d41214 - Browse repository at this point
Copy the full SHA 8d41214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f8e5a9 - Browse repository at this point
Copy the full SHA 4f8e5a9View commit details -
Add: ๋น์์ด ํํฐ๋ง ๊ธฐ๋ฅ ์ถ๊ฐ (#171)
<!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - ๋น์์ด ํํฐ๋ง ๊ธฐ๋ฅ์ ์ถ๊ฐํ์์ต๋๋ค. - ๊ณํ ์์ฑ ์ค ์ ๋ชฉ๊ณผ ๋ด์ฉ์ ๊ฒ์ฆํ ์ ์๋ api๋ฅผ ์ถ๊ฐํ์์ต๋๋ค. <!-- ๋ฆฌ๋ทฐ์ด์๊ฒ ์ด๋ค ๋ถ๋ถ์ ์์ธํ๊ฒ ๋ฆฌ๋ทฐํ ์ง ์์ ํด์ฃผ์ธ์. --> # ๐ To Reviewer - ํ์ฉ ๋จ์ด๋ ์ดํ์ ์ถ๊ฐํ๊ฒ ์ต๋๋ค! - wordBundle ํด๋์ค์ ์์น๊ฐ ๊ณ ๋ฏผ๋ฉ๋๋ค,, <!-- ํ ์คํธ ๋ฐ์ํ ํ ์คํธ ๋ฉ์๋ ์ด๋ฆ๊ณผ ์ด๋ค ํ ์คํธ๋ฅผ ํ๋์ง ์์ฑํด์ฃผ์ธ์. (ex. save_Fail_ByDuplicateEmail) --> # โ ์์ฑํ ํ ์คํธ - [x] badWordFilter_Success - [x] badWordFilter_Success_WithoutBanWord - [x] badWordFilter_Success_WithIgnoreOverlaps - [x] validateContent_Success - [x] validateContent_Success_WithoutBanWord - [x] validateContent_Success(controller test) <!-- ๊ด๋ จ ์ด์ ํ๋ก ํธ์์ ์์ฑํด์ค ์ด์์ ์ฐ๊ด๋๋ PR์ด๋ผ๋ฉด ์ฃผ์์ ํ๊ณ ์์ฑํด์ฃผ์ธ์! --> [//]: # (# ๐ซก ๊ด๋ จ Issue )
Configuration menu - View commit details
-
Copy full SHA for bcc7ac7 - Browse repository at this point
Copy the full SHA bcc7ac7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0c4d87 - Browse repository at this point
Copy the full SHA c0c4d87View commit details -
Configuration menu - View commit details
-
Copy full SHA for effa79f - Browse repository at this point
Copy the full SHA effa79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67ed5b8 - Browse repository at this point
Copy the full SHA 67ed5b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for da65b9e - Browse repository at this point
Copy the full SHA da65b9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83efadf - Browse repository at this point
Copy the full SHA 83efadfView commit details -
Merge: add security util, fix authorization AOP, change root directorโฆ
โฆy path (#175) Merge: add security util, fix authorization AOP, change root directory path
Configuration menu - View commit details
-
Copy full SHA for 9b5a031 - Browse repository at this point
Copy the full SHA 9b5a031View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f46f98 - Browse repository at this point
Copy the full SHA 2f46f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1053115 - Browse repository at this point
Copy the full SHA 1053115View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5659ad - Browse repository at this point
Copy the full SHA a5659adView commit details -
Configuration menu - View commit details
-
Copy full SHA for abebc23 - Browse repository at this point
Copy the full SHA abebc23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 948432e - Browse repository at this point
Copy the full SHA 948432eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5213234 - Browse repository at this point
Copy the full SHA 5213234View commit details -
Configuration menu - View commit details
-
Copy full SHA for 405a1a6 - Browse repository at this point
Copy the full SHA 405a1a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b00b9d - Browse repository at this point
Copy the full SHA 4b00b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea401e - Browse repository at this point
Copy the full SHA 0ea401eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e07297 - Browse repository at this point
Copy the full SHA 7e07297View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8de45d5 - Browse repository at this point
Copy the full SHA 8de45d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5308bd5 - Browse repository at this point
Copy the full SHA 5308bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d29b7cd - Browse repository at this point
Copy the full SHA d29b7cdView commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9340703 - Browse repository at this point
Copy the full SHA 9340703View commit details -
Configuration menu - View commit details
-
Copy full SHA for 379881a - Browse repository at this point
Copy the full SHA 379881aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee14ac - Browse repository at this point
Copy the full SHA 3ee14acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bbc5ee - Browse repository at this point
Copy the full SHA 0bbc5eeView commit details
Commits on Feb 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 206efa5 - Browse repository at this point
Copy the full SHA 206efa5View commit details -
Merge(.plan): plan domain ํฅ์ฌ๊ณ ๋ ์ํคํ ์ฒ ์ ์ฉ (#176)
<!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - ํ๋ ๋๋ฉ์ธ์ ํฅ์ฌ๊ณ ๋ ์ํคํ ์ฒ๋ฅผ ์ ์ฉํ์์ต๋๋ค. <!-- ๋ฆฌ๋ทฐ์ด์๊ฒ ์ด๋ค ๋ถ๋ถ์ ์์ธํ๊ฒ ๋ฆฌ๋ทฐํ ์ง ์์ ํด์ฃผ์ธ์. --> # ๐ To Reviewer - ์ค๋ณต๋๋ ํด๋์ค ์ด๋ฆ์ด ์์ด์ remind ํจํค์ง ๋ด๋ถ์ ์๋ ํด๋์ค ์ด๋ฆ์ ์ผ๊ด์ ์ผ๋ก Plan -> Target์ผ๋ก ๋ณ๊ฒฝํ์์ต๋๋ค - ์ํคํ ์ฒ๋ฅผ ์ ์ฉํ๊ณ ๋๋ ์ค๋ฅ๊ฐ ๋์ ํผ๋๋ฐฑ,๋ฆฌ๋ง์ธ๋ ํจํค์ง ๋ด์ ์ผ๋ถ ํด๋์ค์ ์ฝ๋๋ฅผ ์ต์ํ์ผ๋ก ๋ณ๊ฒฝํ์์ต๋๋ค. - ํผ๋๋ฐฑ ํ ์คํธ์์ ์ค๋ฅ๊ฐ ๋์ ์์๋ก ์ฃผ์ ์ฒ๋ฆฌ ํ์์ต๋๋ค. ๋จธ์งํ๊ธฐ ์ ์ ๊ณ ์ณ๋ณด๊ฒ ์ต๋๋ท - ์ฝ๋๋ ๊ฑฐ์ ์์ ํ์ง ์์์ ์ํคํ ์ฒ ์ ์ฉํ ๊ฒ ์์ฃผ๋ก ๋ด์ฃผ์๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค๐ <!-- ๊ด๋ จ ์ด์ ํ๋ก ํธ์์ ์์ฑํด์ค ์ด์์ ์ฐ๊ด๋๋ PR์ด๋ผ๋ฉด ์ฃผ์์ ํ๊ณ ์์ฑํด์ฃผ์ธ์! --> [//]: # (# ๐ซก ๊ด๋ จ Issue )
Configuration menu - View commit details
-
Copy full SHA for c1bb6e6 - Browse repository at this point
Copy the full SHA c1bb6e6View commit details
Commits on Feb 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78a9fcc - Browse repository at this point
Copy the full SHA 78a9fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5329aa1 - Browse repository at this point
Copy the full SHA 5329aa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76addb9 - Browse repository at this point
Copy the full SHA 76addb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3cb48a - Browse repository at this point
Copy the full SHA d3cb48aView commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 057e912 - Browse repository at this point
Copy the full SHA 057e912View commit details -
Configuration menu - View commit details
-
Copy full SHA for f14fe9d - Browse repository at this point
Copy the full SHA f14fe9dView commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d25af2 - Browse repository at this point
Copy the full SHA 6d25af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9f1c1 - Browse repository at this point
Copy the full SHA 7d9f1c1View commit details -
Add(.footprint) : ๋ฐ์์ทจ ๋๋ฉ์ธ ๊ฐ์ฒด ์ค๊ณ
<!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - ๋ฐ์์ทจ ๋๋ฉ์ธ ๊ฐ์ฒด๋ฅผ ์ค๊ณํ์ต๋๋ค. - ๋๋ฉ์ธ ๊ท์น๊น์ง ๊ตฌํํ์ง ์๊ณ ํ์ํ ๊ฐ์ฒด์ ๊ด๊ณ๋ง ํํํ์ต๋๋ค. - ํผ์๋ง์ ๊ณ ๋ฏผ์ด ๊ธธ์ด์ง๋ ๊ฒ ๊ฐ์ PR ๋จ์๋ฅผ ์งง๊ฒ ํด์ ์ํตํด์ผํ ํ์์ฑ์ ๋๊ผ์ต๋๋ค. - ๋ ผ์๊ฐ ์ด๋ค์ง ํ ํ๋์ ๋๋ฉ์ธ ๊ท์น์ PR ๋จ์๋ก ํด์ ์์ฑํ๋ ค ํฉ๋๋ค. <!-- ๋ฆฌ๋ทฐ์ด์๊ฒ ์ด๋ค ๋ถ๋ถ์ ์์ธํ๊ฒ ๋ฆฌ๋ทฐํ ์ง ์์ ํด์ฃผ์ธ์. --> # ๐ To Reviewer - ๋ค์ํ ํ์์ ํ๊ณ ๋ฅผ ์ถ์ ํด๋์ค์์ ์์๋ฐ๋ ๋ฐฉ์์ผ๋ก ๊ตฌํํ์ต๋๋ค. - ์ถ์ ํด๋์ค ์ ์ฝ์ผ๋ก ์ธํด ์ ์ ๋ฉ์๋๋ฅผ ์ฌ์ฉํด์ ์์ฑํ๋ ๋ฐฉ์์ ๋ณด๋ฅํ๊ณ ์์ฑ์๋ฅผ ์ฌ์ฉํ๊ณ ์์ต๋๋ค. - ์์ฑ์์ ํ๋ผ๋ฏธํฐ๊ฐ ๋ง์ ๋ณ๋์ ํ๋ผ๋ฏธํฐ DTO๋ฅผ ๋ง๋ค๊ณ ์ฌ์ฉ์ ์ ์ ์์ฑ์๋ฅผ ๋ง๋ค์์ต๋๋ค. ๋ค๋ง fixture-monkey์ ์ฅ์ ์ ํตํด ํ ์คํธ ์ฝ๋๋ฅผ ์์ฑํ๋ ค๋ค๋ณด๋ ๋ค์ dto์ ์๋ก์ด ์์ฑ์๋ฅผ ์ถ๊ฐํ๋ ์ด์ํจ์ด ์์ต๋๋ค. - Monkey support์ fixture monkey ์ฌ์ฉ ์ ์ด์ํ๊ฒ ์์ฑ์๋ฅผ ํตํ ๋ฐฉ์์ด ์ ์ฉ๋์ง ์์์ต๋๋ค. ํ ์คํธ ๋ฐ ์กฐ์ฌ ๊ฒฐ๊ณผ FailoverIntrospector๋ฅผ ์ญ์ ํ๊ณ ConstructorPropertiesArbitraryIntrospector ๋ง ์ ์ฉํ์ ์ ๋ฉ๋๋ค. ์ ๋ ํ๋๊ฐ์ด ๋ง์ ๋ฐ๋์ Fixture Monkey๋ฅผ ์ฌ์ฉํ๊ณ ์ถ์๊ณ ๊ณตํต ์ค์ ์ ๋ณ๊ฒฝํ ์ ์์ด ํ ์คํธ ์ฝ๋์ ๋ฉค๋ฒ๋ณ์๋ก Fixture Monkey๋ฅผ ํ ๋ ๋ ์ถ๊ฐ ํ์ต๋๋ค. <!-- ํ ์คํธ ๋ฐ์ํ ํ ์คํธ ๋ฉ์๋ ์ด๋ฆ๊ณผ ์ด๋ค ํ ์คํธ๋ฅผ ํ๋์ง ์์ฑํด์ฃผ์ธ์. (ex. save_Fail_ByDuplicateEmail) --> # โ ์์ฑํ ํ ์คํธ - [x] createFreeFootprint_Success_WithNoException - [x] createKPTFootprint_Success_WithNoException <!-- ๊ด๋ จ ์ด์ ํ๋ก ํธ์์ ์์ฑํด์ค ์ด์์ ์ฐ๊ด๋๋ PR์ด๋ผ๋ฉด ์ฃผ์์ ํ๊ณ ์์ฑํด์ฃผ์ธ์! --> [//]: # (# ๐ซก ๊ด๋ จ Issue )
Configuration menu - View commit details
-
Copy full SHA for f12a177 - Browse repository at this point
Copy the full SHA f12a177View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7aa52b9 - Browse repository at this point
Copy the full SHA 7aa52b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b74add0 - Browse repository at this point
Copy the full SHA b74add0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f9393e - Browse repository at this point
Copy the full SHA 3f9393eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed35d7 - Browse repository at this point
Copy the full SHA 8ed35d7View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 874339b - Browse repository at this point
Copy the full SHA 874339bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b783408 - Browse repository at this point
Copy the full SHA b783408View commit details -
Configuration menu - View commit details
-
Copy full SHA for b90cb94 - Browse repository at this point
Copy the full SHA b90cb94View commit details -
Configuration menu - View commit details
-
Copy full SHA for e801358 - Browse repository at this point
Copy the full SHA e801358View commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a9a2ec0 - Browse repository at this point
Copy the full SHA a9a2ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b963ab6 - Browse repository at this point
Copy the full SHA b963ab6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe9ff15 - Browse repository at this point
Copy the full SHA fe9ff15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 347a1da - Browse repository at this point
Copy the full SHA 347a1daView commit details
Commits on Feb 18, 2024
-
Merge: separate cache dependencies on modules, feat custom assertion (#โฆ
โฆ179) <!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - ์ธ์ฆ ์ชฝ์ ๋ฆฌํฉํ ๋ง ํ์ต๋๋ค. <!-- ๋ฆฌ๋ทฐ์ด์๊ฒ ์ด๋ค ๋ถ๋ถ์ ์์ธํ๊ฒ ๋ฆฌ๋ทฐํ ์ง ์์ ํด์ฃผ์ธ์. --> # ๐ To Reviewer - JWT ๊ด๋ จ ํด๋์ค๋ค์ ์ ๋ฆฌํ์ต๋๋ค. ๊ธฐ์กด์ `JwtValidator`์ ์ญํ ์ด parsingํ๋ ๊ฒ์ ๊ฐ๊น์ `JwtParse`์๊ฒ ์ฑ ์์ ๋ชฐ์์ฃผ์์ต๋๋ค. - ๊ธฐ์กด์ `JwtParser`์ `RawParser`๋ฅผ ๋ง ํผ๋ํด์ ์ฐ๋๋ฏ ํ์ต๋๋ค. ๊ทธ๋์, `RawParser`๋ (ํจํค์ง) ๋ด๋ถ์ ์ผ๋ก ์ฌ์ฉํ๊ณ `JwtParser`๋ ์ธ๋ถ์์ ์ฌ์ฉํ๋๋ก ์์ ํ์ต๋๋ค. - ๊ธฐ์กด์ Redis๋ฅผ ์ฌ์ฉํ๊ธฐ ์ํด `CacheUtil`์ ํ๋์ end-point๋ก ๋๊ณ ์ฌ์ฉํ์ต๋๋ค. ๊ธฐ์กด์ **์ง์ ์ ์ผ๋ก ์ฌ์ฉํด์ ๊ฐํ ์์กด์ฑ์ด ๋ฐ์**ํ๋ค๊ณ ํ๋จํ๊ณ , **๋ชจ๋ ๋ฉ์๋๊ฐ public**์ด๋ผ์ ์๋์ ๋ค๋ฅด๊ฒ ์ฌ์ฉ๋ ์ ์๋ค๊ณ ์๊ฐํ์ต๋๋ค. ๊ทธ๋์, **์ฝํ ์์กด์ฑ์ผ๋ก ์์ **ํ์์ต๋๋ค. - ๊ทธ ๊ณผ์ ์์ **์ค๋ณต๋๋ ์ฝ๋๋ฅผ ์ค์ด๊ธฐ ์ํด์ ์ฝ๋๋ฅผ ์์ถํ๋๋ฐ, ์ฝ๊ฐ ๊ณผํ๋ค**๊ณ ์๊ฐ์ด ๋ค์์ต๋๋ค. ์ฌ๋ฌ๋ถ๋ค์ ์๊ฒฌ์ด ๊ถ๊ธํฉ๋๋ค. - ์ฝํ๋ฆฐ์์ ์๊ฐ์ ๋ฐ์์ **Custom Assertion**์ ๋ง๋ค์์ต๋๋ค. `assertThatAjajaException`์ผ๋ก ์์ธ์ ๋ฉ์์ง๊ฐ ์ผ์นํ๋์ง ์๋์ผ๋ก ํ์ธํฉ๋๋ค! ๋ง๋๋๋ฐ ์ด๋ ต์ง ์์์ ํด๋ดค๋๋ฐ ์ฐ์ค ๋ถ์ ์ฐ์ ๋ ๋๊ณ ์ ์ฐ์ ๋ ๋ ๊ฒ ๊ฐ์ต๋๋ค! **Before** ```java assertThatExceptionOfType(AjajaException.class) .isThrownBy(() -> verifyCertificationService.verify(user.getId(), "certification")) .withMessage(CERTIFICATION_NOT_MATCH.getMessage()); ``` **After** ```java assertThatAjajaException(CERTIFICATION_NOT_MATCH).isThrownBy(() -> verifyCertificationService.verify(user.getId(), "certification") ); ```
Configuration menu - View commit details
-
Copy full SHA for 7230b01 - Browse repository at this point
Copy the full SHA 7230b01View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15ed128 - Browse repository at this point
Copy the full SHA 15ed128View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67b8645 - Browse repository at this point
Copy the full SHA 67b8645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a6fdf - Browse repository at this point
Copy the full SHA 22a6fdfView commit details
Commits on Feb 22, 2024
-
Merge: add discord bot, fix feign client configuration error (#181)
<!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - ๋์ค์ฝ๋ ๋ด์ ์๋ฆผ์ ๋ณด๋ด๋ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ต๋๋ค. <!-- ๋ฆฌ๋ทฐ์ด์๊ฒ ์ด๋ค ๋ถ๋ถ์ ์์ธํ๊ฒ ๋ฆฌ๋ทฐํ ์ง ์์ ํด์ฃผ์ธ์. --> # ๐ To Reviewer - ์ถํ์ ๋์ ๋ FCM์ ๋๋นํ์ฌ EDA๋ฅผ ๊ตฌ์ฑํ๊ณ , ํ์ฌ๋ ์น๋ช ์ ์ธ ์ค๋ฅ(Unexpected Exception)์ด ๋ฐ์ํ์ ๋ ์๋ฆผ์ ๋ฐ๋๋ก ํด๋์์ต๋๋ค. - ๋์ค์ ์ ๊ท ์ ์ ์ ๊ฐ์ , ์ธ๋ถ API ํธ์ถ ๋ฑ์ ๋ํด์ ๋ด์ผ๋ก ์๋ฆผ์ ๋ฐ์ ์์ ์ ๋๋ค. - feign์์ ์๋ชป๋ ๋น ๋ฑ๋ก์ผ๋ก ์ธํด์ ๋ชจ๋ client๊ฐ naver header๋ฅผ ์ฌ์ฉํ๋ ๊ฒ์ ์์ ํ์์ต๋๋ค. <!-- ํ ์คํธ ๋ฐ์ํ ํ ์คํธ ๋ฉ์๋ ์ด๋ฆ๊ณผ ์ด๋ค ํ ์คํธ๋ฅผ ํ๋์ง ์์ฑํด์ฃผ์ธ์. (ex. save_Fail_ByDuplicateEmail) --> # โ ์์ฑํ ํ ์คํธ - [x] onDiscordEvent_Success
Configuration menu - View commit details
-
Copy full SHA for 299f7c1 - Browse repository at this point
Copy the full SHA 299f7c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 438a655 - Browse repository at this point
Copy the full SHA 438a655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a85e1b - Browse repository at this point
Copy the full SHA 5a85e1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24e80fa - Browse repository at this point
Copy the full SHA 24e80faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe3096 - Browse repository at this point
Copy the full SHA 1fe3096View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66f668d - Browse repository at this point
Copy the full SHA 66f668dView commit details -
Fix: handle proxy error (#183)
<!-- PR ๋ด์ฉ ์ด๋ค ์์ ์ ํ๋์ง ์์ฑํด์ฃผ์ธ์! PR์ด ๋๋ฌด ํฌ๋ฉด ๋๋ฌด ๋ง์ ๋ด์ฉ์ด ๋ค์ด๊ฐ๊ฒ ์ฃ ? --> # ๐ ์ด๋ค PR์ธ๊ฐ์? - proxy ์๋ฌ ํด๊ฒฐ
Configuration menu - View commit details
-
Copy full SHA for 57488bc - Browse repository at this point
Copy the full SHA 57488bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2827a6 - Browse repository at this point
Copy the full SHA c2827a6View commit details